Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][mig] auth_oidc_environment #737

Merged
merged 7 commits into from
Jan 20, 2025
Merged

[18.0][mig] auth_oidc_environment #737

merged 7 commits into from
Jan 20, 2025

Conversation

hparfr
Copy link
Contributor

@hparfr hparfr commented Dec 16, 2024

No description provided.

@hparfr hparfr force-pushed the 18.0-mig-auth_oidc_environment branch from e41aae2 to 8933e77 Compare December 16, 2024 18:06
@hparfr
Copy link
Contributor Author

hparfr commented Dec 16, 2024

@adrienpeiffer

@hparfr
Copy link
Contributor Author

hparfr commented Dec 17, 2024

@sbidoul @simahawk @AnizR
you were reviewers of the v16 port
#561

sbidoul
sbidoul approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with v16, it is identical.

AnizR
AnizR approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, nothing changed since 16.0

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hparfr
Copy link
Contributor Author

hparfr commented Jan 20, 2025

@sbidoul can you please merge ?

@sbidoul
Copy link
Member

sbidoul commented Jan 20, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-737-by-sbidoul-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 96c8147 into OCA:18.0 Jan 20, 2025
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad9d922. Thanks a lot for contributing to OCA. ❤️

@hparfr hparfr deleted the 18.0-mig-auth_oidc_environment branch February 11, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@AnizR AnizR AnizR approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hparfr @OCA-git-bot @sbidoul @AnizR @adrienpeiffer @mymage