Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] auth_session_timeout: Fix pre-migrate script #736

Merged
merged 1 commit into from
Mar 3, 2025
Merged

[17.0] auth_session_timeout: Fix pre-migrate script #736

merged 1 commit into from
Mar 3, 2025

Conversation

Robrechtc
Copy link

@Robrechtc Robrechtc commented Dec 12, 2024 •
edited
Loading

The pre-migrate script should use cr instead of env as parameter.

@Robrechtc Robrechtc changed the title [17.0] auth_session_timeout: Fix Pre-migrate script [17.0] auth_session_timeout: Fix pre-migrate script Dec 12, 2024
sebalix
sebalix approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, indeed the env is usable only if def migrate is decorated with @openupgrade.migrate (but no need to introduce this dependency here)

@sebalix sebalix added the bug label Mar 3, 2025
@sebalix sebalix added this to the 17.0 milestone Mar 3, 2025
@sebalix
Copy link
Contributor

sebalix commented Mar 3, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-736-by-sebalix-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3f4e0b7 into OCA:17.0 Mar 3, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 68a5523. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
bug merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Robrechtc @sebalix @OCA-git-bot