Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [MIG] auth_ldaps: Migration to 17.0 #643

Merged
merged 34 commits into from
Dec 29, 2024
Merged

[17.0] [MIG] auth_ldaps: Migration to 17.0 #643

merged 34 commits into from
Dec 29, 2024

Conversation

rven
Copy link

@rven rven commented May 6, 2024

No description provided.

etobella and others added 30 commits May 6, 2024 09:32
@etobella @rven
[ADD] auth_ldaps
f8a0dfd
@alexey-pelykh @rven
[MIG] auth_ldaps: Migration to 12.0
d2db33d
@alexey-pelykh @rven
[FIX] auth_ldaps: Specify ldap as Python dependency and safely import it
7a0fc34
@alexey-pelykh @rven
[12.0][FIX] auth_ldap_attribute_sync & auth_ldaps: author name
90c9ea8
@rven
[IMP] auth_ldaps: black, isort, prettier
45c56e9
@rven
[13.0][MIG] auth_ldaps
28d819d
@gurneyalex @rven
fix linting
a81890c
@gurneyalex @rven
add python-ldap dependency
272f5aa
@oca-travis @rven
[UPD] Update auth_ldaps.pot
f7c7d2a
@OCA-git-bot @rven
[UPD] README.rst
92a7229
@alexey-pelykh @rven
[UPD] Brainbean Apps => CorporateHub
0b82f93
@OCA-git-bot @rven
[UPD] README.rst
87cf16e
@OCA-git-bot @rven
auth_ldaps 13.0.1.0.1
89d89d9
@gurneyalex @rven
[MIG][14.0] auth_ldaps
5d9b67a
@oca-travis @rven
[UPD] Update auth_ldaps.pot
c4fafb8
@OCA-git-bot @rven
[UPD] README.rst
059fdda
@primes2h @rven
Added translation using Weblate (Italian)
92cca4c
@primes2h @rven
Translated using Weblate (Italian)
c3526ec 
Currently translated at 100.0% (6 of 6 strings)

Translation: server-auth-14.0/server-auth-14.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
@primes2h @rven
Translated using Weblate (Italian)
5fea19d 
Currently translated at 100.0% (6 of 6 strings)

Translation: server-auth-14.0/server-auth-14.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-auth_ldaps/it/
@huguesdk @rven
[FIX] fix ldaps certificate verification
3a82e6c
@OCA-git-bot @rven
auth_ldaps 14.0.1.0.1
1a6c3f1
@albig @rven
[IMP] auth_ldaps: black, isort, prettier
bea6d38
@albig @rven
[MIG] auth_ldaps: Migration to 15.0
92ed5fc
@albig @rven
Update readme with oca-gen-addon-readme
39ad450
@OCA-git-bot @rven
[UPD] README.rst
0a5e604
@weblate @rven
Update translation files
5ffaa85 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-15.0/server-auth-15.0-auth_ldaps
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-auth_ldaps/
@anothingguy @rven
[16.0][MIG] auth_ldaps: Migration to 16.0
75741ab
@rven
[UPD] Update auth_ldaps.pot
ffa291b
@OCA-git-bot @rven
[UPD] README.rst
9df95fa
@OCA-git-bot @rven
[UPD] README.rst
d416e84
@rven rven mentioned this pull request May 6, 2024
Open
20 tasks
@pedrobaeza
Copy link
Member

/ocabot migration auth_ldaps

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 6, 2024
acsonefho
acsonefho approved these changes May 24, 2024
View reviewed changes
auth_ldaps/models/res_company_ldap.py Outdated

class CompanyLDAP(models.Model):
_inherit = "res.company.ldap"
_description = "Company LDAP configuration"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as it's an _inherit.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that it's better not to do this, but this was also present in 16.0, 15.0, etc.

Maybe it's better to fix it after upgrade with a "fix" PR, so the fix can be backported.

@ryanc-me ryanc-me mentioned this pull request Jul 31, 2024
Open
@ryanc-me
Copy link

@rven I'm in the process of testing this at a client site - seems to be working well so far. Thanks for your efforts here!

Do you have some time to solve the review changes?

I would be happy to take over this PR if you're short on time. :)

@rven rven force-pushed the 17.0-mig-auth_ldaps branch from 12f7f8f to e8f06e7 Compare August 1, 2024 07:14
@rven
Copy link
Author

rven commented Aug 1, 2024

@ryanc-me Changes implemented, also added a separate commit for the removal of the _description attribute.

@rven rven force-pushed the 17.0-mig-auth_ldaps branch from e8f06e7 to 1337793 Compare August 1, 2024 07:44
@ryanc-me
Copy link

ryanc-me commented Aug 1, 2024

Awesome, thanks @rven! I'll re-test this today then do a review, so hopefully it can be merged :)

If you have a moment, maybe you can check out #675, #674, #673 - if one of them is useful for you, you could provide a review.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-643-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1bdc7db into OCA:17.0 Dec 29, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bfd34e0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanc-me ryanc-me ryanc-me approved these changes

@acsonefho acsonefho acsonefho approved these changes

@nojusZeta nojusZeta nojusZeta approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.