[14.0] [FIX] auth_jwt: Unhandled PyJWKClientError in _get_key #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks the validation loop with next_validator_id
|
Hi @sbidoul, |
|
/ocabot merge patch @paradoxxxzero do you plan to forward port? |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cff6f5f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit 5e726ac breaks the next_validator_id loop.
_get_keycallsjwks_client.get_signing_key(kid)which can raise PyJWKClientError which is not caught by the validation loop (only catching Unauthorized)Putting
_get_keyin the preceding try except fix this problem since it catches all Exception