Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][14.0] auth_saml: readme an link to the runboat #623

Closed
wants to merge 1 commit into from

Conversation

leemannd
Copy link
Contributor

These changes where introduced with the backport of the refactoring of the module auth_saml
in -> cd6082a

In this PR I change them back to values related to 14.0 for more consistency

@leemannd
Copy link
Contributor Author

Hello @vincent-hatakeyama Can you have a look at this README and runboat link update?

Copy link

@apf-c2c apf-c2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincent-hatakeyama
Copy link
Contributor

Those files are automatically updated by the runbot.

For the information about the changes, you need to edit readme/HISTORY.rst that is used by the runbot.

@vincent-hatakeyama
Copy link
Contributor

@OCA/tools-maintainers The author of this PR tries to fix the index.html file directly but that file is supposed to be generated automatically. The README of the 14.0 branch is correct but auth_saml/ references the 15.0 branch. Is there a way to force the bot to do the update?

@dreispt
Copy link
Member

dreispt commented Apr 30, 2024

@vincent-hatakeyama Something went wrong there. Recent version of pre-commit ensure the README is generated.

@dreispt
Copy link
Member

dreispt commented Apr 30, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 30, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@thomaspaulb
Copy link
Contributor

@dreispt @pedrobaeza Should we maybe do a manual merge in this situation? It's just readme updates so there's no harm done

@hbrunn
Copy link
Member

hbrunn commented Apr 30, 2024

seems to me you fell victim of OCA/oca-addons-repo-template#250 (comment) - retry?

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 30, 2024
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

You have to wait until the situation with Codecov is resolved.

@leemannd
Copy link
Contributor Author

Closing as old and outdated

@leemannd leemannd closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants