-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX][14.0] auth_saml: readme an link to the runboat #623
Conversation
Hello @vincent-hatakeyama Can you have a look at this README and runboat link update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Those files are automatically updated by the runbot. For the information about the changes, you need to edit readme/HISTORY.rst that is used by the runbot. |
@OCA/tools-maintainers The author of this PR tries to fix the index.html file directly but that file is supposed to be generated automatically. The README of the 14.0 branch is correct but auth_saml/ references the 15.0 branch. Is there a way to force the bot to do the update? |
@vincent-hatakeyama Something went wrong there. Recent version of pre-commit ensure the README is generated. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
1 similar comment
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-dreispt-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@dreispt @pedrobaeza Should we maybe do a manual merge in this situation? It's just readme updates so there's no harm done |
seems to me you fell victim of OCA/oca-addons-repo-template#250 (comment) - retry? /ocabot merge patch |
On my way to merge this fine PR! |
@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-623-by-hbrunn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
You have to wait until the situation with Codecov is resolved. |
Closing as old and outdated |
These changes where introduced with the backport of the refactoring of the module auth_saml
in -> cd6082a
In this PR I change them back to values related to 14.0 for more consistency