[17.0][MIG] auth_oidc #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap-wtioit
force-pushed
the
17.0-mig-auth_oidc
branch
from
de42dcf to
6dfc679
Compare
update manifest, add README, update requirements.txt
Add some install instructions and configuration instructions for keycloak.
Avoid replacing the access token by the id token. This may cause confusion. Copy a little piece of code from auth_oauth() method, to make the code easier to follow, and prepare for implementing the authorization code flow.
This is not a recommended scenario, but this prepares the code for using PKCE
ap-wtioit
force-pushed
the
17.0-mig-auth_oidc
branch
from
6dfc679 to
49552c9
Compare
create an upstream merge request after OCA#393 is merged
ap-wtioit
force-pushed
the
17.0-mig-auth_oidc
branch
from
49552c9 to
4e1f9d6
Compare
wtaferner
approved these changes
Mar 26, 2024
|
@sbidoul |
sbidoul
approved these changes
Mar 27, 2024
|
Examined with my now favorite review command: |
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 185c0a0. Thanks a lot for contributing to OCA. ❤️ |
|
/ocabot migration auth_oidc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of auth_oidc to 17.0
Info @wt-io-it