[IMP][15.0]auth_saml: add tests and fix password reset when deactivating the config settings #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vincent-hatakeyama, |
|
@leemannd the CI is red;-) |
|
@gurneyalex It would be better now. It's a forward port of #599 |
leemannd
changed the title
gurneyalex
approved these changes
Jan 8, 2024
Please squash and make sure that the commit message follows the usual OCA conventions. |
leemannd
force-pushed
the
imp-15.0-auth_saml-add_tests
branch
from
770de41 to
d7c3433
Compare
leemannd
force-pushed
the
imp-15.0-auth_saml-add_tests
branch
from
d7c3433 to
26a1baf
Compare
|
Hello @vincent-hatakeyama If it is ok for you a merge is welcome |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7fc0fce. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #599