Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] auth_oidc_portal: Link OAuth provider on portal user create #572

Closed
wants to merge 1 commit into from

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Nov 14, 2023

Adds OAuth Provider field to grant portal access wizard

image

feedback highly welcome.

@CRogos CRogos changed the title [ADD] auth_oidc_portal: Link OAuth provider on portal user create [16.0][ADD] auth_oidc_portal: Link OAuth provider on portal user create Nov 14, 2023
@CRogos CRogos closed this Nov 14, 2023
@CRogos CRogos reopened this Nov 14, 2023
@CRogos
Copy link
Contributor Author

CRogos commented Nov 14, 2023

Anyone an idea why this unit test is failing after adding my module?

2023-11-14 15:26:59,666 831 ERROR odoo odoo.addons.password_security.tests.test_signup: FAIL: TestPasswordSecuritySignup.test_02_signup_user_success
Traceback (most recent call last):
  File "/__w/server-auth/server-auth/password_security/tests/test_signup.py", line 63, in test_02_signup_user_success
    self.assertEqual(
AssertionError: '/my' != '/web/login_successful?account_created=True'
- /my
+ /web/login_successful?account_created=True

@CRogos CRogos force-pushed the 16.0-add-auth_oidc_portal branch from 7484abc to 304173d Compare November 16, 2023 08:26
@CRogos
Copy link
Contributor Author

CRogos commented Nov 16, 2023

@sbidoul: do you have an hint, how to fix this test compatibility issue?

@CRogos CRogos force-pushed the 16.0-add-auth_oidc_portal branch from 304173d to 770959b Compare November 19, 2023 20:45
@CRogos
Copy link
Contributor Author

CRogos commented Nov 19, 2023

The test fails, when the "portal" module is installed. I've changed the test to be compatible with the changed return url.

@CRogos CRogos force-pushed the 16.0-add-auth_oidc_portal branch 2 times, most recently from 6601ce5 to d11866a Compare November 19, 2023 22:22
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@CRogos
Copy link
Contributor Author

CRogos commented Mar 24, 2024

@dreispt what do you think of this addon?

@CRogos CRogos force-pushed the 16.0-add-auth_oidc_portal branch from d11866a to 8c73a80 Compare March 24, 2024 12:46
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 31, 2024
Copy link

github-actions bot commented Aug 4, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
@dreispt dreispt added needs review and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Aug 22, 2024
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 22, 2024
@github-actions github-actions bot closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants