Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] auth_oauth_signup #521

Closed
wants to merge 1 commit into from

Conversation

mlaitinen
Copy link

Enable sign up for users logging in using OAuth2 on a per-provider basis, overriding the global setting.

Without this module, your options are:

  1. allow sign up for everyone who can access the login page
  2. import users (and provide values for oauth_provider_id and oauth_uid) before they log in for the first time.

@mlaitinen mlaitinen marked this pull request as draft June 11, 2023 12:54
@mlaitinen mlaitinen force-pushed the 16.0-auth_oauth_signup branch from 913631f to 9293c9a Compare June 11, 2023 13:26
@mlaitinen mlaitinen marked this pull request as ready for review June 11, 2023 13:29
@mlaitinen mlaitinen changed the title [ADD] auth_oauth_signup [16.0][ADD] auth_oauth_signup Jun 11, 2023
@jaenbox
Copy link

jaenbox commented Sep 27, 2023

In the event that the variable 'provider' has the value 'false,' the exception error is not caught, and the error is not displayed.
You can fix it with this code. if provider and provider.allow_signup:

@mlaitinen mlaitinen force-pushed the 16.0-auth_oauth_signup branch from 9293c9a to 891c01d Compare January 22, 2024 15:04
@mlaitinen
Copy link
Author

In the event that the variable 'provider' has the value 'false,' the exception error is not caught, and the error is not displayed. You can fix it with this code. if provider and provider.allow_signup:

Well spotted, thanks. I fixed it and added a test to make sure that SignupError gets raised when sign up fails and provider is False.

@jaenbox
Copy link

jaenbox commented May 21, 2024

LGTM Functional Review

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@github-actions github-actions bot closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants