Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[18.0][MIG] auth_saml: Migration to 18.0
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,8 @@ | |
| from odoo.exceptions import AccessDenied, UserError, ValidationError | ||
| from odoo.tests import HttpCase, tagged | ||
|
|
||
| from odoo.addons.auth_saml.controllers.main import fragment_to_query_string | ||
|
|
||
| from .fake_idp import DummyResponse, FakeIDP | ||
|
|
||
|
|
||
|
|
@@ -78,6 +80,13 @@ def setUp(self): | |
| ) | ||
| ) | ||
|
|
||
| # Define a sample function to test the decorator | ||
| def dummy_function(self, **kw): | ||
| return "Function executed" | ||
|
|
||
| # Apply the decorator to the dummy function | ||
| self.decorated_function = fragment_to_query_string(dummy_function) | ||
|
|
||
| def test_ensure_provider_appears_on_login(self): | ||
| # SAML provider should be listed in the login page | ||
| response = self.url_open("/web/login") | ||
|
|
@@ -125,7 +134,7 @@ def test__compute_sp_metadata_url__provider_has_sp_baseurl(self): | |
| {"p": self.saml_provider.id, "d": self.env.cr.dbname} | ||
| ) | ||
| expected_url = urllib.parse.urljoin( | ||
| "http://example.com", (f"/auth_saml/metadata?{expected_qs}") | ||
| ) | ||
| # Assert that sp_metadata_url is set correctly | ||
| self.assertEqual(self.saml_provider.sp_metadata_url, expected_url) | ||
|
|
@@ -200,7 +209,10 @@ def test_login_no_saml(self): | |
|
|
||
| # Try to log in with a non-existing SAML token | ||
| with self.assertRaises(AccessDenied): | ||
| self.user._check_credentials( | ||
| {"type": "password", "password": "test_saml_token"}, | ||
| {"interactive": True}, | ||
| ) | ||
|
|
||
| redirect_url = self.saml_provider._get_auth_request() | ||
| self.assertIn("http://localhost:8000/sso/redirect?SAMLRequest=", redirect_url) | ||
|
|
@@ -254,7 +266,10 @@ def test_login_with_saml(self): | |
|
|
||
| # We should not be able to log in with the wrong token | ||
| with self.assertRaises(AccessDenied): | ||
| self.user._check_credentials( | ||
| {"type": "password", "password": "WRONG_TOKEN"}, | ||
| {"interactive": True}, | ||
| ) | ||
|
|
||
| # User should now be able to log in with the token | ||
| self.authenticate(user="[email protected]", password=token) | ||
|
|
@@ -268,8 +283,9 @@ def test_disallow_user_password_when_changing_ir_config_parameter(self): | |
| ).value = "False" | ||
| # The password should be blank and the user should not be able to connect | ||
| with self.assertRaises(AccessDenied): | ||
| self.user._check_credentials( | ||
| {"type": "password", "password": "NesTNSte9340D720te>/-A"}, | ||
| {"interactive": True}, | ||
| ) | ||
|
|
||
| def test_disallow_user_password_new_user(self): | ||
|
|
@@ -332,18 +348,19 @@ def test_disallow_user_password_no_password_set(self): | |
| with self.assertRaises(ValidationError): | ||
| user.password = "new password" | ||
|
|
||
| def test_disallow_user_password_on_option_disable(self): | ||
| """Test that existing user password is deleted when adding an SAML provider when | ||
| the disallow option is set.""" | ||
| self.authenticate(user="[email protected]", password="Lu,ums-7vRU>0i]=YDLa") | ||
| # change the option | ||
| self.browse_ref( | ||
| "auth_saml.allow_saml_uid_and_internal_password" | ||
| ).value = "False" | ||
| with self.assertRaises(AccessDenied): | ||
| self.user._check_credentials( | ||
| {"type": "password", "password": "Lu,ums-7vRU>0i]=YDLa"}, | ||
| {"interactive": True}, | ||
| ) | ||
|
|
||
| def test_disallow_user_admin_can_have_password(self): | ||
| """Test that admin can have its password set | ||
|
|
@@ -417,6 +434,50 @@ def test_disallow_user_password_when_changing_settings(self): | |
| ).execute() | ||
|
|
||
| with self.assertRaises(AccessDenied): | ||
| self.user._check_credentials( | ||
| {"type": "password", "password": "NesTNSte9340D720te>/-A"}, | ||
| {"interactive": True}, | ||
| ) | ||
|
|
||
| def test_fragment_to_query_string_no_kw(self): | ||
| """Test the case where no keyword arguments are passed.""" | ||
| response = self.decorated_function(self) | ||
| expected_html = """<html><head><script> | ||
| var l = window.location; | ||
| var q = l.hash.substring(1); | ||
| var r = '/' + l.search; | ||
| if(q.length !== 0) { | ||
| var s = l.search ? (l.search === '?' ? '' : '&') : '?'; | ||
| r = l.pathname + l.search + s + q; | ||
| } | ||
| window.location = r; | ||
| </script></head><body></body></html>""" | ||
| self.assertEqual(response.strip(), expected_html.strip()) | ||
|
|
||
| def test_fragment_to_query_string_with_kw(self): | ||
| """Test the case where keyword arguments are passed.""" | ||
| response = self.decorated_function(self, key="value") | ||
| self.assertEqual(response, "Function executed") | ||
|
|
||
| def test_sig_alg_selection(self): | ||
| """Test that _sig_alg_selection is returning correct selection.""" | ||
| expected_selection = [ | ||
| ("SIG_RSA_SHA1", "SIG_RSA_SHA1"), | ||
| ("SIG_RSA_SHA224", "SIG_RSA_SHA224"), | ||
| ("SIG_RSA_SHA256", "SIG_RSA_SHA256"), | ||
| ("SIG_RSA_SHA384", "SIG_RSA_SHA384"), | ||
| ("SIG_RSA_SHA512", "SIG_RSA_SHA512"), | ||
| ] | ||
| self.assertEqual(self.saml_provider._sig_alg_selection(), expected_selection) | ||
|
|
||
| def test_saml_metadata_invalid_provider(self): | ||
| """Accessing SAML metadata with an invalid provider ID should return 404.""" | ||
| response = self.url_open(f"/auth_saml/metadata?p=999999&d={self.env.cr.dbname}") | ||
| self.assertEqual(response.status_code, 404) | ||
| self.assertIn("Unknown provider", response.text) | ||
|
|
||
| def test_saml_metadata_missing_parameters(self): | ||
| """Accessing the SAML metadata endpoint without params should return 404.""" | ||
| response = self.url_open("/auth_saml/metadata") | ||
| self.assertEqual(response.status_code, 404) | ||
| self.assertIn("Missing parameters", response.text) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters