[IMP] rma_sale: Avoid computing RMA move unnecessarily #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @chienandalu, |
sbejaoui
added a commit
to acsone/rma
that referenced
this pull request
Feb 4, 2025
sbejaoui
force-pushed
the
16.0-rma_sale-sbj2
branch
from
f2e116a to
4f3333e
Compare
In the RMA sale wizard, the move is computed after the wizard line is generated. This is inefficient since the line is created after iterating through the moves related to the sale order. Assigning the move to the wizard line prevents another issue where all RMAs would be linked to a single move if the sale order line is associated with multiple moves.
sbejaoui
force-pushed
the
16.0-rma_sale-sbj2
branch
from
4f3333e to
0c35a96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the RMA sale wizard, the move is computed after the wizard line is generated. This is inefficient since the line is created after iterating through the moves related to the sale order.
Assigning the move to the wizard line prevents another issue where all RMAs would be linked to a single move if the sale order line is associated with multiple moves.