Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] rma: add dashboard #429

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] rma: add dashboard #429

wants to merge 1 commit into from

Conversation

sbejaoui
Copy link
Contributor

image

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

@rousseldenis rousseldenis added this to the 16.0 milestone Oct 16, 2024
@sbejaoui sbejaoui force-pushed the 16.0-rma_dashboard-sbj branch 2 times, most recently from 11fda8d to 8ffd913 Compare October 17, 2024 09:00
@sbejaoui sbejaoui force-pushed the 16.0-rma_dashboard-sbj branch from 8ffd913 to 70872c5 Compare October 17, 2024 12:04
@sbejaoui sbejaoui requested a review from pedrobaeza October 17, 2024 12:22
chienandalu
chienandalu approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎 👍

@rousseldenis
Copy link
Contributor

rousseldenis commented Oct 17, 2024 •
edited
Loading

@sbejaoui As requested operation is optional, I would have added a new card for those awaiting operation.

As those RMA don't appear in any current card.

What do you think ?

@sbejaoui
Copy link
Contributor Author

@sbejaoui As requested operation is optional, I would have added a new card for those awaiting operation.

As those RMA don't appear in any current card.

What do you think ?

The operation is required to confirm the RMA. While it may be useful to show users RMAs awaiting operation, the working cost is much higher than the added value, in my opinion, as the dashboard is a Kanban view for the operation model and can't display a card for a non-existent record without diving deep into JS widgets.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 16, 2025
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 23, 2025
@pedrobaeza
Copy link
Member

ping @sbejaoui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza Awaiting requested review from pedrobaeza

Assignees
No one assigned
Labels
enhancement needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sbejaoui @OCA-git-bot @rousseldenis @pedrobaeza @chienandalu