[15.0][MIG] base_import_async #430
Conversation
base_import_async/__manifest__.py
Outdated
| 'web.assets_qweb': [ | ||
| 'base_import_async/static/src/xml/import.xml', | ||
| ], | ||
| }, | ||
| "installable": False, |
There was a problem hiding this comment.
Thank you @RosSinch :)
It is still not installable 🤔
There was a problem hiding this comment.
I've given up :)
I did it.
But could you please explain to me why it should be installable in v15 if it wasn't in v14?
There was a problem hiding this comment.
"installable": False, was false in v14 because nobody did the migration work in this version, so it could not be used in v14. Perhaps odoo will still install it using the -i option, not sure, but this would be a kind of bug, the module would be shown as uninstallable in the UI.
As I understand you actually did the migration work so the module runs on v15, then the module should be flagged as installable, it would be a pity if the module cannot be installed if you made it installable, right? :)
There was a problem hiding this comment.
Yes, you are absolutely right. It should be installable and it can, because the work is done for this.
There was a problem hiding this comment.
Build is 🔴
Also, please, when you get back to it, squash your commits and rewrite the 1 remaining as [15.0][MIG] base_import_async
|
Should we expect this migration to be merged any time soon? |
simahawk
changed the title
|
Note that there's another PR now here #434. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Now that this one was closed we could continue with the other one that's in better shape. |
No description provided.