Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] purchase_manual_currency #2521

Open
wants to merge 17 commits into
base: 17.0
Choose a base branch
from

Conversation

ArnauCForgeFlow
Copy link
Contributor

@ArnauCForgeFlow ArnauCForgeFlow commented Jan 21, 2025

Migration to 17.0

return True

@api.model
def _fields_view_get(
Copy link
Contributor

@ThiagoMForgeFlow ThiagoMForgeFlow Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change _fields_view_get to get_view(self, view_id=None, view_type="form", **options):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks!

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 17.0-mig-purchase_manual_currency branch from 566de62 to beaec54 Compare January 27, 2025 09:22
Copy link
Contributor

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review 👍

@ThiagoMForgeFlow
Copy link
Contributor

Dependency merged!

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 17.0-mig-purchase_manual_currency branch from beaec54 to 196b7e1 Compare January 29, 2025 08:46
Copy link
Contributor

@ThiagoMForgeFlow ThiagoMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Saran440
Copy link
Member

Saran440 commented Mar 4, 2025

Functional Test, Manual currency is not send data to Invoice

Step to test:

  1. Create PO with manual currency
    Selection_011

  2. Create bill, manual currency is not checked
    Selection_012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants