[15.0][FIX] project_timeline: Allow to install this module with project_enterprise #1447
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HugoCLU @carlos-lopez-tecnativa Could you help me to review 🙏 |
pedrobaeza
reviewed
Mar 13, 2025
| @@ -11,18 +11,33 @@ class ReportProjectTaskUser(models.Model): | |||
| planned_date_end = fields.Datetime(readonly=True) | |||
|
|
|||
| def _select(self): | |||
| res = super()._select() | |||
| if "planned_date_end" in res: | |||
There was a problem hiding this comment.
This is too broad. You may have other field planned_date_end_custom and do matching.
There was a problem hiding this comment.
I already make the change @pedrobaeza could you help me to review if this is the change you requested 🙏
…erprise This PR fixes an issue added in commit OCA@3689f1d When the module project_timeline is installed in a database with the module project_enterprise, it raises the following error: psycopg2.errors.DuplicateColumn: column "planned_date_end" specified more than once This is because the field planned_date_end is defined in both modules. This PR change the field name from planned_date_end to planned_date_end_custom in order to avoid the conflict.
alan196
force-pushed
the
15.0-fix-planned-date-end
branch
from
81b7b4e to
afa63a3
Compare
|
No, that was not what I requested. What I requested is that you make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue added in commit 3689f1d
When the module project_timeline is installed in a database with the module project_enterprise, it raises the following error:
This is because the field planned_date_end is defined in both modules.
This PR checks if the field is already defined in the query before adding it.
Fixes #1433