Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] project consumable #1419

Open
wants to merge 4 commits into
base: 17.0
Choose a base branch
from
Open

[17.0] project consumable #1419

wants to merge 4 commits into from

Conversation

petrus-v
Copy link
Contributor

@petrus-v petrus-v commented Jan 21, 2025 •
edited
Loading

Migrate project consumable #1410 from v14.0

Work in progress:

  • refactor do not depends on hr_timesheet and avoid conflict with it, the shame is that odoo is not using polymorphism to generate account.move.line 😭 so odoo assume that an account.analytic.line with a project_id are timesheet line making very hard to add a new kind of account.analytic.line linked to the project
  • in project.update profitability right panel add consumable/materials somehow => smart button + other cost is fine to me for the time being.

@petrus-v petrus-v force-pushed the 17.0-project_consumable branch from e15137a to 63535e0 Compare January 21, 2025 10:03
@petrus-v petrus-v marked this pull request as draft January 21, 2025 15:07
@petrus-v petrus-v marked this pull request as ready for review February 4, 2025 14:56
@petrus-v petrus-v force-pushed the 17.0-project_consumable branch 2 times, most recently from 0007d75 to 70f211a Compare February 4, 2025 15:21
@petrus-v
[REF] project_consumable: improve consumable detection
74a568c 
In the previous implementation project_id field was reused on account move line
but a lot of the odoo code source assume that an account move line with a project_id
is a timesheet, making very hard to distinguish Materials and Timesheet.

Adding a consumable_project_id it avoid to breaks existing code make module
much more easier to maintains
@petrus-v petrus-v force-pushed the 17.0-project_consumable branch from 70f211a to 74a568c Compare February 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@petrus-v