[15.0][ADD] project_task_required_project: project task required project. #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelgarciadelachica
changed the title
angelgarciadelachica
force-pushed
the
15.0-add-project_task_required_project
branch
3 times, most recently
from
4a12f9b to
450b93f
Compare
|
@HaraldPanten @luis-ron Can you review this PR? |
ValentinVinagre
suggested changes
Jan 21, 2025
|
|
||
| @api.constrains("project_id") | ||
| def _check_project_id_not_null(self): | ||
| if self.env.company.is_project_required and any( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@manuelregidor can you review it? |
angelgarciadelachica
force-pushed
the
15.0-add-project_task_required_project
branch
2 times, most recently
from
b34d31d to
c7c1e4c
Compare
project_task_required_project/tests/test_project_task_required_project.py
Outdated
Show resolved
Hide resolved
angelgarciadelachica
force-pushed
the
15.0-add-project_task_required_project
branch
from
c7c1e4c to
182c52f
Compare
manuelregidor
approved these changes
Jan 21, 2025
leemannd
reviewed
Jan 21, 2025
leemannd
reviewed
Jan 21, 2025
angelgarciadelachica
force-pushed
the
15.0-add-project_task_required_project
branch
from
182c52f to
e439ee1
Compare
HaraldPanten
approved these changes
Jan 23, 2025
|
@leemannd Is this PR ready now? THX for reviewing! |
leemannd
approved these changes
Jan 23, 2025
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 650dc87. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module obliges you to select a project when creating or editing a project task.
[T-7322]