Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] project_task_code #1409

Open
wants to merge 70 commits into
base: 18.0
Choose a base branch
from

Conversation

wpichler
Copy link

@wpichler wpichler commented Jan 3, 2025

oihane and others added 30 commits January 3, 2025 17:47
OCA Transbot updated translations from Transifex

[MIG] project_task_code: Migrate to 10.0

Edit init and XML

Add env

Change task_ids to tasks

Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result)
- use the `model_create_multi` decorator on the create override for
future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings)

Translation: project-12.0/project-12.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_code/
OCA-git-bot and others added 15 commits January 3, 2025 17:47
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/
Search task by its code in x2m fields.
@wpichler wpichler force-pushed the 18.0-mig-project_task_code branch 3 times, most recently from 0533790 to 031f8cf Compare January 3, 2025 17:40
@wpichler wpichler force-pushed the 18.0-mig-project_task_code branch from 031f8cf to 4242081 Compare January 3, 2025 17:46
@wpichler wpichler changed the title 18.0 mig project task code [18.0] [MIG] project_task_code Jan 3, 2025
@wpichler wpichler changed the title [18.0] [MIG] project_task_code [18.0][MIG] project_task_code Jan 3, 2025
@wpichler
Copy link
Author

wpichler commented Jan 3, 2025

The Diff in Code Coverage is because of this function:

    @property
    def SELF_WRITABLE_FIELDS(self):
        return super().SELF_WRITABLE_FIELDS | PROJECT_TASK_WRITABLE_FIELDS

Is for something like this really a unit test necessary ?

@wpichler wpichler mentioned this pull request Jan 6, 2025
19 tasks
Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! merge?

@norlinhenrik
Copy link

norlinhenrik commented Mar 31, 2025

Hello! Thank you for migrating this to 18.0. I see that many features in project_task_code and project_sequence are general. And I have just made an issue to discuss two modules for general sequence features. The repo includes sequence_project with sequences for projects and tasks, based on project_sequence and project_task_code.

Please try it out and let me know what you think. Is it a good or bad idea to replace project_sequence and project_task_code with sequence_project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.