-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] project_task_code #1409
base: 18.0
Are you sure you want to change the base?
Conversation
OCA Transbot updated translations from Transifex [MIG] project_task_code: Migrate to 10.0 Edit init and XML Add env Change task_ids to tasks Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result) - use the `model_create_multi` decorator on the create override for future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings) Translation: project-12.0/project-12.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-13.0/project-13.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_code/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/
Search task by its code in x2m fields.
0533790
to
031f8cf
Compare
031f8cf
to
4242081
Compare
The Diff in Code Coverage is because of this function: @property
def SELF_WRITABLE_FIELDS(self):
return super().SELF_WRITABLE_FIELDS | PROJECT_TASK_WRITABLE_FIELDS Is for something like this really a unit test necessary ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! merge?
Hello! Thank you for migrating this to 18.0. I see that many features in Please try it out and let me know what you think. Is it a good or bad idea to replace |
Standard Migration - based on https://github.com/nedaszilinskas/project/tree/17.0-mig-project_task_code