Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] project_update_visible #1201

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

adasatorres
Copy link

This addon modifies the form view of the product.update model to make the project_id field visible.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it is ok, but you should need to apply some nitpicking changes 😄

project_update_visible/views/project_update_views.xml Outdated Show resolved Hide resolved
project_update_visible/views/project_update_views.xml Outdated Show resolved Hide resolved
project_update_visible/__manifest__.py Outdated Show resolved Hide resolved
@adasatorres adasatorres force-pushed the 16.0-add-project_update_visible branch 2 times, most recently from 3f9b403 to d610dd1 Compare November 30, 2023 08:02
@adasatorres
Copy link
Author

@etobella Thanks for your help, I have already made the changes.

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am already approving it, as it is just a small comment that will be easily solved.

Remember to squash all your commits in a single one.

You should need git rebase to squash them 😉

@@ -0,0 +1,18 @@
{
# Copyright 2023 Binhex (https://www.binhex.cloud)
Copy link
Member

@etobella etobella Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be on top of the file

# Copyright 2023 Binhex (https://www.binhex.cloud)
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
{
....

Check for example any other module from the repository 😉

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 30, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this first PR. You are on the road!

project_update_visible/readme/CONTRIBUTORS.rst Outdated Show resolved Hide resolved
project_update_visible/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
project_update_visible/__manifest__.py Outdated Show resolved Hide resolved
@adasatorres adasatorres force-pushed the 16.0-add-project_update_visible branch from d610dd1 to e554c3a Compare December 1, 2023 09:52
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1201-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3113ee6 into OCA:16.0 Dec 11, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 40ae177. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants