-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] project_update_visible #1201
[16.0][ADD] project_update_visible #1201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it is ok, but you should need to apply some nitpicking changes 😄
3f9b403
to
d610dd1
Compare
@etobella Thanks for your help, I have already made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am already approving it, as it is just a small comment that will be easily solved.
Remember to squash all your commits in a single one.
You should need git rebase
to squash them 😉
@@ -0,0 +1,18 @@ | |||
{ | |||
# Copyright 2023 Binhex (https://www.binhex.cloud) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright should be on top of the file
# Copyright 2023 Binhex (https://www.binhex.cloud)
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
{
....
Check for example any other module from the repository 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this first PR. You are on the road!
d610dd1
to
e554c3a
Compare
This PR has the |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 40ae177. Thanks a lot for contributing to OCA. ❤️ |
This addon modifies the form view of the product.update model to make the project_id field visible.