Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] hr_payroll #171

Closed
wants to merge 1 commit into from
Closed

[ADD] hr_payroll #171

wants to merge 1 commit into from

Conversation

max3903
Copy link
Member

@max3903 max3903 commented Nov 2, 2024

@max3903 max3903 added enhancement New feature or request needs review labels Nov 2, 2024
@max3903 max3903 added this to the 17.0 milestone Nov 2, 2024
@max3903 max3903 force-pushed the 17.0-add-hr_payroll branch 2 times, most recently from fdabcc6 to 98f862e Compare November 2, 2024 05:08
@max3903 max3903 force-pushed the 17.0-add-hr_payroll branch from 98f862e to 9581ccc Compare November 2, 2024 05:11
@nimarosa
Copy link
Contributor

nimarosa commented Jan 6, 2025

We can't add such module because it will conflict with Enterprise modules, that's why the modules don't have the same name.

@nimarosa nimarosa closed this Jan 6, 2025
@max3903
Copy link
Member Author

max3903 commented Jan 6, 2025

@nimarosa So what are you suggesting? Maintaining 2 separate modules: one for Community, one for Enterprise?

@OCA/human-resources-maintainers Any other options or opinion?

I believe this question will come back with other localizations. Same answer?

@nimarosa
Copy link
Contributor

nimarosa commented Jan 6, 2025

@max3903 What you can do is to create a module in your localization repository, which will install OCA payroll as hr_payroll.

We can't have it in the main repository because it leads to confusion and incompatibility issues with enterprise version. We changed the name to allow people using enterprise to install OCA Payroll module if they want. So if we include a module named hr_payroll in the repository, we will have compatibility issues.

What you need to do is to publish your payroll localization in the Mexican OCA localization repository. That way, you can create the module and maintain compatibility without affecting the payroll repository.

All l10n localizations belongs to each localization repository, it cannot be published in the main payroll repository.

You need to do it here:
https://github.com/OCA/l10n-mexico

I hope I clarified things for you. Regards.

@max3903
Copy link
Member Author

max3903 commented Jan 6, 2025

@nimarosa So you are suggesting that each and every localization host their own hr_payroll module in their own repo, right?

@nimarosa
Copy link
Contributor

nimarosa commented Jan 6, 2025

@max3903 not the full payroll module. I'm saying that they host the hr_payroll dummy module which just install OCA payroll module.

It's the same you suggested but in a localization repo level and not in the main repository. That if you want to use the same module for enterprise and community. The other solution is to just have a community version and change "hr_payroll" to "payroll" in your manifest.

@max3903 max3903 deleted the 17.0-add-hr_payroll branch January 6, 2025 22:09
@max3903
Copy link
Member Author

max3903 commented Jan 6, 2025

@nimarosa Thanks for your clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants