[17.0][MIG] partner_country_lang: Migration to 17.0 #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT38559 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: partner-contact-13.0/partner-contact-13.0-partner_country_lang Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_country_lang/
[UPD] Update partner_country_lang.pot [UPD] README.rst [UPD] README.rst
|
You should convert the onchange to compute and you won't need that dependency switch. |
|
/ocabot migration partner_country_lang |
victoralmau
force-pushed
the
17.0-mig-partner_country_lang
branch
from
f128cca to
8697a6f
Compare
Changes done. |
pedrobaeza
reviewed
Feb 5, 2025
| class ResPartner(models.Model): | ||
| _inherit = "res.partner" | ||
|
|
||
| lang = fields.Selection(compute="_compute_lang") |
There was a problem hiding this comment.
Always add a comment indicating that this is an override
Suggested change
| lang = fields.Selection(compute="_compute_lang") | |
| # Add the compute method on the existing field | |
| lang = fields.Selection(compute="_compute_lang") |
|
|
||
| @api.depends("country_id") | ||
| def _compute_lang(self): | ||
| for item in self: |
There was a problem hiding this comment.
Be preventive if the method already exists in other module:
Suggested change
| for item in self: | |
| for item in self: | |
| if hasattr(super(), "_compute_lang"): | |
| super()._compute_lang() |
| @api.depends("country_id") | ||
| def _compute_lang(self): | ||
| for item in self: | ||
| item.lang = item.country_id.lang or item.lang |
There was a problem hiding this comment.
Isn't more declarative this way and avoid unneeded assignations?
Suggested change
| item.lang = item.country_id.lang or item.lang | |
| if item.country_id.lang: | |
| item.lang = item.country_id.lang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
@Tecnativa TT54939