Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] partner_tier_validation: Migrate to 17.0 #1732

Open
wants to merge 21 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] partner_tier_validation: Migrate to 17.0 #1732

wants to merge 21 commits into from

Conversation

patrickrwilson
Copy link
Contributor

No description provided.

@patrickrwilson patrickrwilson force-pushed the 17.0-mig-partner_tier_validation branch 2 times, most recently from ec0b607 to 5eb0a5c Compare April 9, 2024 16:02
@Loregs2
Copy link

Loregs2 commented Jul 4, 2024

LGTM

@Abranes
Copy link
Member

Abranes commented Jul 16, 2024

@patrickrwilson, could you do a rebase and force push to trigger the Runboat build?

@patrickrwilson
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @patrickrwilson you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
jaenbox
jaenbox approved these changes Nov 21, 2024
View reviewed changes
Copy link

@jaenbox jaenbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dreispt and others added 19 commits November 21, 2024 08:33
@dreispt
[ADD] partner_tier_validation
5f298ac
@Freni-OSI
[14.0][MIG]partner_tier_validation
077c89b
@Freni-OSI
[14.0][IMP]Improved partner_tier_validation
a44c702
@dreispt
[FIX] partner_tier_validation: workflow was not working
3134a08
@oca-travis
partner_tier_validation 14.0.1.1.0
397cb2f
@patrickrwilson
[IMP]
0f551f4 
- Added new optional tier definition for is_company = true.
- Added auto active if no validation needed during create.
- Added reset validation during write for specific fields.

[FIX] Code White Space Formatting

[IMP] Reviewer Suggestions

[IMP] Added Tests
@oca-travis
partner_tier_validation 14.0.2.0.0
0549998
@victoralmau
[FIX] partner_tier_validation: Defer rule activation for compatibility
36fa520 
Having this rule activated by default in tests environments makes other tests to fail due to the additional constraint not expected by them, so what we are doing is:

- Having the rule deactivated by default.
- On a post-init hook, we activate it only if we are not in a test environment.
- On own modules tests, we activate it as well

TT30292
@dreispt
[REF] partner_tier_validation: do not archive, depend on partner_stage
c8528b8
@oca-travis
partner_tier_validation 14.0.3.0.0
42c1c92
@dreispt
[FIX] partner_tier_validation: create does not need custom code, rest…
1c1e825 
…art validation on controlled field changes
@dreispt
[FIX] partner_tier_validation: fix tests
c3541e6
@OCA-git-bot
partner_tier_validation 14.0.3.0.1
80d2585
@patrickrwilson
[IMP] partner_tier_validation (Prevent bypass)
1fb9094 
This prevents a scenario where a user can bypass validation by moving the partner to a 'cancel' stage and then moving it back to confirmed.
@OCA-git-bot
partner_tier_validation 14.0.3.0.2
3b1d69b
@BT-dmontull
[IMP] partner_tier_validation: black, isort, prettier
32a1c84
@BT-dmontull
[15.0][MIG] partner_tier_validation: Migration to 15.0
e68f258
@Urvisha-OSI
[IMP] partner_tier_validation: pre-commit stuff
ab08e47
@Urvisha-OSI
[MIG] partner_tier_validation: Migrated to 16.0
b2fbe49
@patrickrwilson patrickrwilson force-pushed the 17.0-mig-partner_tier_validation branch from 5eb0a5c to 69fe30e Compare November 21, 2024 16:36
@patrickrwilson
Copy link
Contributor Author

@patrickrwilson, could you do a rebase and force push to trigger the Runboat build?

Rebased as requested, all green now

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 24, 2024
Cedric-Pigeon
Cedric-Pigeon approved these changes Dec 18, 2024
View reviewed changes
Copy link

@Cedric-Pigeon Cedric-Pigeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ok and functionnaly tested

@miikanissi miikanissi mentioned this pull request Feb 4, 2025
Open
miikanissi
miikanissi approved these changes Feb 4, 2025
View reviewed changes
Copy link

@miikanissi miikanissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Created a migration for 18.0 based off this at #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miikanissi miikanissi miikanissi approved these changes

@jaenbox jaenbox jaenbox approved these changes

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

@Abranes Abranes Abranes approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.