[15.0][MIG] partner_identification #1270
Conversation
* [IMP] improve module description
* [IMP] Remove useless comments
* [FIX] Complete incomplete sentence
* [IMP] Replace field 'state' by 'status' in res_partner_id_number
* [IMP] Add new field 'Place of Issuance'
* [FIX] Readme formatting
* [IMP] status is now a selection field
* [IMP] use method to provide the default value for validation_code
* [IMP] Add help texts
* [FIX] Add missing constrains on category_id in res_partner.id_number
The number must be validated also when we change the category
Allow for context override of validations using ``id_no_validate``
OCA#419) * [IMP] partner_identification: Add field computation and inverses * Add methods to allow for computation and inverse of an ID field of a specific category type * [IMP] partner_identification: Add search option
|
@Freni-OSI This looks good but can you squash all the admin commits. Below is the reference to this requirement for migrating to 15.0... https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 "Squash administrative commits (if any) with the previous commit for reducing commit noise. They are named as "[UPD] README.rst", "[UPD] Update $MODULE.pot", "Update translation files" and similar names, and comes from OCA-git-bot, oca-travis or oca-transbot. IMPORTANT: Don't squash legit translation commits, authored by their translators, with the message "Translated using Weblate (...)"." |
[FIX] Tests [FIX] data sequence Fix openerp to odoo in comment [REM] at_install, post_install [ADD] Model descriptions [REM] Extra spaces
Currently translated at 97.9% (46 of 47 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_identification/it/
Currently translated at 97.9% (46 of 47 strings) Translation: partner-contact-12.0/partner-contact-12.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_identification/es/
Currently translated at 100.0% (47 of 47 strings) Translation: partner-contact-13.0/partner-contact-13.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_identification/zh_CN/
Currently translated at 100.0% (47 of 47 strings) Translation: partner-contact-13.0/partner-contact-13.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_identification/es_AR/
Currently translated at 21.3% (10 of 47 strings) Translation: partner-contact-13.0/partner-contact-13.0-partner_identification Translate-URL: https://translation.odoo-community.org/projects/partner-contact-13-0/partner-contact-13-0-partner_identification/nl/
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1270-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
| ) | ||
| % (self.name, e) | ||
| ) | ||
| msg = ( |
There was a problem hiding this comment.
@Freni-OSI @dreispt This is not good !
You should format after the translation!
There was a problem hiding this comment.
@Freni-OSI will you be fixing this? Can I help?
There was a problem hiding this comment.
Can you check and review it again? Thanks
|
@Freni-OSI Do you plan to fix this ? |
|
@Freni-OSI ?? |
Freni-OSI
force-pushed
the
15.0_MIG_partner_identification
branch
from
3c96c9d to
a997ac3
Compare
Freni-OSI
requested review from
rousseldenis and
andreschenkels
and removed request for
rousseldenis and
andreschenkels
| ) | ||
| raise ValidationError(_(msg)) |
There was a problem hiding this comment.
@Freni-OSI Hich, you cannot do that!
You should format the result of translation function:
raise ValidationError(_(msg).format(...))
|
Superseded by #1436 |
No description provided.