[FIX] migrate_translations_to_jsonb: avoid ir_translation terms cleanup #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jun 18, 2024
openupgradelib/openupgrade_160.py
Outdated
| env.cr, field | ||
| ) | ||
| for query in migrate_queries: | ||
|
|
|
There's a limitation here as the core method executes a query inside the method that expects the table |
|
I recommend then that this method renames the table before, and restores it after. |
We're making use of core's `_get_translation_upgrade_queries` which aside from provide the proper queries to upgrade the translated fields to the new json structure tries to cleanup the former ir_tanslation records. In OpenUpgrade we try to keep historic info after migration so we're able to quickly react to possible inconsistencies. Besides that, we need to rename the `ir_translation` table if we want to work with this method. TT49615
chienandalu
force-pushed
the
fix-migrate_translations_to_jsonb-delete-records
branch
from
7b2b12b to
743bf56
Compare
|
Now that I see the diff, why previous approach replacing inside the query didn't serve? |
1 task
|
See the code I linked in my previous comment. There's a query execution inside the method that we can't change |
|
OK, understood @marielejeune FYI |
pedrobaeza
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're making use of core's
_get_translation_upgrade_querieswhich aside from provide the proper queries to upgrade the translated fields to the new json structure tries to cleanup the former ir_tanslation records.In OpenUpgrade we try to keep historic info after migration so we're able to quickly react to possible inconsistencies.
cc @Tecnativa TT49615