[16.0][IMP] mis_builder: allow to export multiple report in one xls #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbidoul, |
AnizR
force-pushed
the
imp-mis-report-xlsx
branch
4 times, most recently
from
650a65d to
3392ff4
Compare
|
This looks good at first sight. If we don't have test coverage for this, it might be a good occasion to add some. |
AnizR
force-pushed
the
imp-mis-report-xlsx
branch
from
3392ff4 to
e81811a
Compare
There's already a test that checks that it is possible to generate a xlsx report. I've added a small one for generation of a report over 2 instances. |
sbidoul
reviewed
Jan 28, 2025
AnizR
force-pushed
the
imp-mis-report-xlsx
branch
from
e81811a to
ce944fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to export multiple reports at once.
In one '.xls' where every report is a sheet.
To do so, I added one action 'Export XLS' visible on tree view of
mis_report_instance.