Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] mis_builder: enforce unique style name #656

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

chaule97
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul added the 17.0 label Dec 10, 2024
@@ -133,6 +132,10 @@ def check_positive_val(self):
hide_always_inherit = fields.Boolean(default=True)
hide_always = fields.Boolean(default=False)

_sql_constraints = [
("style_name_event_uniq", "unique(name)", "Style name should be unique")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("style_name_event_uniq", "unique(name)", "Style name should be unique")
("style_name_uniq", "unique(name)", "Style name should be unique")

A little detail.

@chaule97 chaule97 force-pushed the 17.0-upd-enforce-unique-style-name branch from 019288f to f12a94f Compare December 12, 2024 05:12
@sbidoul
Copy link
Member

sbidoul commented Dec 16, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-656-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 16, 2024
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-656-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0d49311 into OCA:17.0 Dec 16, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 57ef952. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants