Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mis_builder: use sudo when calling ir.ui.view #611

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

cav-adhoc
Copy link

@cav-adhoc cav-adhoc commented May 30, 2024

When you try to access to account move lines inside a MIS report with an user that has no admin rights, it returns an Access Error.
That is because the function _get_drilldown_model_views() is trying to get the types by calling ir.ui.view model without sudo permitions.

Here is a video replicating the error: https://app.screencastify.com/v3/watch/mw9vsXxOosnvNKLSfKtc
Regads

@cav-adhoc cav-adhoc marked this pull request as ready for review May 31, 2024 13:18
Copy link
Contributor

@jjscarafia jjscarafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjscarafia
Copy link
Contributor

@IT-Ideas Can you please check thise fix.
Seems it's related to this improvement #587

cc @sbidoul

Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@sbidoul
Copy link
Member

sbidoul commented Jun 5, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-611-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eee463f into OCA:16.0 Jun 5, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79c9ea3. Thanks a lot for contributing to OCA. ❤️

@IT-Ideas
Copy link

IT-Ideas commented Jun 5, 2024

@IT-Ideas Can you please check thise fix.

Seems it's related to this improvement #587

cc @sbidoul

Thanks for the fix!

@jjscarafia jjscarafia deleted the 16.0-t-75459-cav branch June 5, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants