[IMP] mis_builder: allow definition of style expression on subkpi level

OCA · Aug 26, 2024 · f41e35b · f41e35b
1 parent 3aa42b4
commit f41e35b
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/mis_builder/models/kpimatrix.py b/mis_builder/models/kpimatrix.py
@@ -251,16 +251,29 @@ def set_values_detail_account(
                 else:
                     val_comment = f"{row.kpi.name} = {row.kpi.expression}"
             cell_style_props = row.style_props
-            if row.kpi.style_expression:
+
+            style_expression = ""
+            if (
+                row.kpi.multi
+                and subcol.subkpi
+                and row.kpi.expression_ids.filtered(
+                    lambda rec, subkpi=subcol.subkpi: rec.subkpi_id == subkpi
+                ).style_expression
+            ):
+                style_expression = row.kpi.expression_ids.filtered(
+                    lambda rec, subkpi=subcol.subkpi: rec.subkpi_id == subkpi
+                ).style_expression
+            elif row.kpi.style_expression:
+                style_expression = row.kpi.style_expression
+
+            if style_expression:
                 # evaluate style expression
                 try:
-                    style_name = mis_safe_eval(
-                        row.kpi.style_expression, col.locals_dict
-                    )
+                    style_name = mis_safe_eval(style_expression, col.locals_dict)
                 except Exception:
                     _logger.error(
                         "Error evaluating style expression <%s>",
-                        row.kpi.style_expression,
+                        style_expression,
                         exc_info=True,
                     )
                 if style_name:

diff --git a/mis_builder/models/mis_report.py b/mis_builder/models/mis_report.py
@@ -298,6 +298,11 @@ class MisReportKpiExpression(models.Model):
     # TODO FIXME set readonly=True when onchange('subkpi_ids') below works
     subkpi_id = fields.Many2one("mis.report.subkpi", readonly=False, ondelete="cascade")
 
+    style_expression = fields.Char(
+        help="An expression that returns a style depending on the KPI value. "
+        "Such style is applied on top of the row style.",
+    )
+
     _sql_constraints = [
         (
             "subkpi_kpi_unique",

diff --git a/mis_builder/views/mis_report.xml b/mis_builder/views/mis_report.xml
@@ -142,6 +142,7 @@
                                         domain="[('report_id', '=', parent.report_id)]"
                                     />
                                     <field name="name" />
+                                    <field name="style_expression" />
                                 </tree>
                             </field>
                             <field