Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 #3071

Merged
merged 19 commits into from
Jul 12, 2024
Merged

[16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 #3071

merged 19 commits into from
Jul 12, 2024

Conversation

RodrigoBM
Copy link
Contributor

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-l10n_es_aeat_sii_invoice_summary branch from 58db194 to 8af9292 Compare June 7, 2023 09:02
@RodrigoBM RodrigoBM changed the title [16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 [WIP][16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 Jun 7, 2023
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-l10n_es_aeat_sii_invoice_summary branch from 8af9292 to 8398c1c Compare June 7, 2023 09:15
@SoniaViciana
Copy link

LGTM!

Envío al SII de factura agrupada de simplificadas:
image

Envío al SII de rectificativa agrupada de simplificadas (la única diferencia es que los importes aparecen en negativo):

image

Gracias,

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-l10n_es_aeat_sii_invoice_summary branch from 8398c1c to 10c16a2 Compare June 7, 2023 14:40
@RodrigoBM RodrigoBM changed the title [WIP][16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 [16.0][MIG] l10n_es_aeat_sii_invoice_summary: Migration to 16.0 Jun 7, 2023
@SoniaViciana SoniaViciana mentioned this pull request Jul 11, 2023
Merged
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 24, 2023
@github-actions github-actions bot closed this Jan 28, 2024
ljsalvatierra-factorlibre
ljsalvatierra-factorlibre reviewed Mar 22, 2024
View reviewed changes
l10n_es_aeat_sii_invoice_summary/models/account_move.py Outdated
tipo_factura = "F4"
if self.sii_invoice_summary_start:
if self.sii_invoice_summary_start == self.sii_invoice_summary_end:
tipo_factura = "F2" if self.move_type == "out_invoice" else "R5"
tipo_factura = "F2" if self.is_inbound() else "R5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El método incluye más tipos, ¿es correcto?

    @api.model
    def get_inbound_types(self, include_receipts=True):
        return ['out_invoice', 'in_refund'] + (include_receipts and ['out_receipt'] or [])

    def is_inbound(self, include_receipts=True):
        return self.move_type in self.get_inbound_types(include_receipts)

l10n_es_aeat_sii_invoice_summary/views/account_move_view.xml Outdated
<field
name="sii_invoice_summary_start"
attrs="{'invisible': [('is_invoice_summary', '=', False)]}"
attrs="{'invisible': ['|', ('move_type', 'not in', ('out_invoice','out_refund')), ('is_invoice_summary', '=', False)]}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Es necesario esto? Parece redundante.

@ljsalvatierra-factorlibre
Copy link
Contributor

Hola @OCA/local-spain-maintainers, ¿se podría reabrir el PR por favor?

@pedrobaeza pedrobaeza reopened this Mar 22, 2024
@pedrobaeza
Copy link
Member

Mencionad por favor en el README que esto es una alternativa al l10n_es_pos_sii.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@pedrobaeza
Copy link
Member

/ocabot migration l10n_es_aeat_sii_invoice_summary

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 13, 2024
Open
54 tasks
VRodrigo and others added 11 commits July 11, 2024 10:19
@VRodrigo @aritzolea
[ADD] l10n_es_aeat_sii_invoice_summary : añadir resumen de facturas
53deba0
@omar7r @aritzolea
[MIG] l10n_es_aeat_sii_invoice_summary: Backport from 11.0 to 10.0
b1765fa 
[ADD] icon.png

[UPD] Update l10n_es_aeat_sii_invoice_summary.pot

[UPD] README.rst

[UPD] README.rst
@victoralmau @aritzolea
[IMP] l10n_es_aeat_sii_invoice_summary: black, isort, prettier
4bcfc04
@ramiadavid @aritzolea
[MIG] l10n_es_aeat_sii_invoice_summary: Migration to 14.0
2769019
@ramiadavid @aritzolea
[IMP] l10n_es_aeat_sii_invoice_summary: añadir rectificativas y tests
e08c42b
@victoralmau @aritzolea
[MIG] l10n_es_aeat_sii_invoice_summary: Finish migration 14.0
94ac5ef 
TT49186
@aritzolea
[UPD] Update l10n_es_aeat_sii_invoice_summary.pot
c0663c6
@OCA-git-bot @aritzolea
[BOT] post-merge updates
09cfeff
@victoralmau @aritzolea
[IMP] l10n_es_aeat_sii_invoice_summary: Show summary fields only on c…
81c6051 
…ustomer invoices

TT49186
@OCA-git-bot @aritzolea
[BOT] post-merge updates
9c68415
@victoralmau @aritzolea
[IMP] l10n_es_aeat_sii_invoice_summary: Define a specific string for …
7865ec7 
…the fields in form view

TT49186
oca-ci and others added 8 commits July 11, 2024 10:19
@aritzolea aritzolea force-pushed the 16.0-mig-l10n_es_aeat_sii_invoice_summary branch from 10c16a2 to 91bdd72 Compare July 12, 2024 08:02
@aritzolea
Copy link
Contributor

@pedrobaeza Readme actualizado con el comentario de que es una alternativa a l10n_es_pos_sii y actualizado el historial de commits del módulo, ahora queda mucho mas simple la migración

pedrobaeza
pedrobaeza approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3071-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit cc124d5 into OCA:16.0 Jul 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 77e0950. Thanks a lot for contributing to OCA. ❤️

@aritzolea aritzolea deleted the 16.0-mig-l10n_es_aeat_sii_invoice_summary branch July 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre ljsalvatierra-factorlibre left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@SoniaViciana SoniaViciana SoniaViciana approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.