Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 mig l10n it rea #611

Merged
merged 16 commits into from
Oct 22, 2018
Merged

11.0 mig l10n it rea #611

merged 16 commits into from
Oct 22, 2018

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Oct 15, 2018 •
edited
Loading

@primes2h primes2h mentioned this pull request Oct 15, 2018
Closed
35 tasks
@eLBati
Copy link
Member

eLBati commented Oct 16, 2018

@primes2h puoi dare un occhio anche a #612 e dirmi cosa ne pensi?

hurrinico and others added 14 commits October 16, 2018 16:17
@primes2h
[ADD] Add rea to v8
cf2611d 
[FIX] Add readme

[FIX] fix province

[FIX] Module name and description

[FIX] Fixed Register

[FIX] rem descr from __openerp__
@yvaucher @primes2h
Add bug tracker link on README.rst
03b0903
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
2b5b556
@sbidoul @primes2h
[UPD] prefix versions with 8.0
d890c87
@pedrobaeza @primes2h
[MIG] Make modules uninstallable
91fe944
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
eb8d1ed
@eLBati @primes2h
porting l10n_it_rea to 9.0
d926d8d 
FIX bug tracker and empty keys
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
d10c40d
@sbidoul @primes2h
[FIX] remove en.po that was erroneously created by transbot
dc051af
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
38c61a8
@pedrobaeza @primes2h
[MIG] Make modules uninstallable
b215e3b 
[MIG] Rename manifest files
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
3afbf68
@andrea4ever @primes2h
[MIG] l10n_it_rea: Migrated to 10.0
7ebaa94 
[FIX] © -> Copyright, and make module installable

[FIX] Enconding on py files
[UPD] Readme
[FIX] openerp -> odoo in xml tag

Add Authors, use https on oca web site
@oca-transbot @primes2h
OCA Transbot updated translations from Transifex
2d4bacf 
[UPD] Update l10n_it_rea.pot
@primes2h primes2h force-pushed the 11.0-mig-l10n_it_rea branch from 06be032 to 358fb50 Compare October 16, 2018 14:21
@primes2h
Copy link
Contributor Author

@primes2h puoi dare un occhio anche a #612 e dirmi cosa ne pensi?

In effetti ci stavo pensando anch'io, mi sembra un'ottima idea.
Ti dirò, forse le informazioni REA meriterebbero anche una scheda a parte, a fianco delle "Informazioni generali" dell'Azienda.
Un'idea potrebbe essere quella di inserirle come sezione dn una scheda "Informazioni CCIAA" più ampia che comprenda i dati della Camera di Commercio.
Però a quel punto sarebbe da rivedere il modulo, a partire dal nome.

@eLBati eLBati mentioned this pull request Oct 18, 2018
Merged
primes2h and others added 2 commits October 18, 2018 17:58
@primes2h
[MIG] l10n_it_rea: Migration to 11.0
059b547
@eLBati @primes2h
FIX REA fields order (OCA#612)
5bfaa09 
ADD REA fields to copany and compute company_registry accordingly
@primes2h primes2h force-pushed the 11.0-mig-l10n_it_rea branch from 358fb50 to 5bfaa09 Compare October 18, 2018 16:27
eLBati
eLBati approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@eLBati eLBati merged commit db8916d into OCA:11.0 Oct 22, 2018
SimoRubi
SimoRubi reviewed Oct 22, 2018
View reviewed changes
l10n_it_rea/models/res_company.py
('LN', 'Not in liquidation')], 'Liquidation State',
related='partner_id.rea_liquidation_state')

@api.onchange(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the related data in the partner does not recompute the company_registry, here the steps:

  1. Fill the data in the company: the company_registry is correctly filled.
  2. Go to the partner bound to the company and change a field.
  3. Go back to the company: company_registry is incorrect (it still has the old computed value)

Maybe a computed field would fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimoRubi it can't be a computed field because it must be freely editable for possible non Italian companies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe the behavior I described should be included in the 'known bugs`

@primes2h primes2h deleted the 11.0-mig-l10n_it_rea branch February 3, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eLBati eLBati eLBati approved these changes

@SimoRubi SimoRubi SimoRubi left review comments

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@primes2h @eLBati @tafaRU @SimoRubi @yvaucher @oca-transbot @sbidoul @pedrobaeza @andrea4ever