Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] l10n_it_riba_sale_commission: adapt to partial_settlement refactor #4577

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][FIX] l10n_it_riba_sale_commission: adapt to partial_settlement refactor #4577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions l10n_it_riba_sale_commission/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

from datetime import date, timedelta

from odoo import fields, models

Expand All @@ -9,51 +8,3 @@ class AccountMove(models.Model):
_inherit = "account.move"

no_commission = fields.Boolean(string="Without commissions")

def _get_reconciled_invoices_partials(self):
"""
If a partial payment is an sbf Riba payment and the safety days haven't
passed yet, I exclude the payment from the partials list where commissions
will be generated.
"""
res = super()._get_reconciled_invoices_partials()
to_remove = []
for (
partial,
amount,
counterpart_line,
) in res:
riba_mv_line = self.env["riba.distinta.move.line"].search(
[("move_line_id", "=", partial.debit_move_id.id)]
)
if riba_mv_line:
riba_type = riba_mv_line.riba_line_id.type
if (
riba_mv_line.riba_line_id.due_date
+ timedelta(days=riba_mv_line.riba_line_id.config_id.safety_days)
> date.today()
) and riba_type == "sbf":
to_remove.append((partial, amount, counterpart_line))
return [item for item in res if item not in to_remove]


class AccountInvoiceLineAgent(models.Model):
_inherit = "account.invoice.line.agent"

def _skip_future_payments(self, date_payment_to):
if self.invoice_id.is_riba_payment:
dates = [
line.date_maturity
+ timedelta(
max(
line.mapped(
"distinta_line_ids.riba_line_id.config_id.safety_days"
),
default=0,
)
)
for line in self.invoice_id.line_ids.filtered(lambda r: r.date_maturity)
]
if dates:
return date_payment_to < max(dates)
return super()._skip_future_payments(date_payment_to)
Loading