-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] l10n_it_vat_registries #3080
Conversation
/ocabot migration l10n_it_vat_registries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revisione Tecnica:
- Installazione OK
- Test unitari OK
class TestRegistry(TransactionCase): | ||
def test_invoice_and_report(self): | ||
test_date = fields.Date.today() | ||
self.journal = self.env["account.journal"].search([("type", "=", "sale")])[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.journal = self.env["account.journal"].search([("type", "=", "sale")])[0] | |
self.journal = self.env["account.journal"].search([("type", "=", "sale")], limit=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cambia il layout, molto chiaro
Functional test OK
Currently translated at 75.0% (45 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/
Currently translated at 95.0% (57 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/ Translated using Weblate (Italian) Currently translated at 96.7% (58 of 60 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
[UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/
Currently translated at 96.6% (57 of 59 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Currently translated at 96.6% (57 of 59 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Negative tax line in supplier invoice, must be negative in vat register line
Currently translated at 98.3% (58 of 59 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
This PR has the |
<field name="type_tax_use" position="after"> | ||
<field name="exclude_from_registries" /> | ||
<field | ||
name="cee_type" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chissà se questo campo è effettivamente ancora usato da qualcuno. Si potrebbe fare un sondaggio ed eventualmente rimuoverlo.
Lo scrivo solo come appunto, non bloccante per la PR
5f2c597
to
b84d01e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
C'è qualche altra cosa che è bloccante per la PR? |
@eLBati puoi aggiornare la tua review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie della PR!
Potresti modificare la storia dei commit come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests?
merge @eLBati ? |
|
b84d01e
to
e80a231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok . test funzionali ok anche con le varie richieste fatte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok test
Prendo in carico per fare le modifiche mancanti |
7bd93bc
to
04fd29a
Compare
04fd29a
to
9694c33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sostituita da #3564
Migration l10n_it_vat_registries from 14.0 to 16.0
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing