Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] l10n_it_vat_registries #3080

Closed
wants to merge 46 commits into from

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Dec 2, 2022

Migration l10n_it_vat_registries from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@tafaRU
Copy link
Member

tafaRU commented Dec 2, 2022

/ocabot migration l10n_it_vat_registries

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 2, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 2, 2022
80 tasks
Copy link
Contributor

@TonyMasciI TonyMasciI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisione Tecnica:

  • Installazione OK
  • Test unitari OK

class TestRegistry(TransactionCase):
def test_invoice_and_report(self):
test_date = fields.Date.today()
self.journal = self.env["account.journal"].search([("type", "=", "sale")])[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.journal = self.env["account.journal"].search([("type", "=", "sale")])[0]
self.journal = self.env["account.journal"].search([("type", "=", "sale")], limit=1)

Copy link

@marco-marchiori marco-marchiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cambia il layout, molto chiaro
Functional test OK

@andreampiovesana
Copy link
Contributor

Gli importi sono allineati a sx, li sposterei a dx, se visualizzo su browser si vedono box altrimenti su libreoffice o altri visualizatori pdf non si vedono, allego screenshot:

image

eLBati and others added 22 commits June 6, 2023 14:52
Currently translated at 75.0% (45 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/
Currently translated at 95.0% (57 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

Translated using Weblate (Italian)

Currently translated at 96.7% (58 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/

Translated using Weblate (Italian)

Currently translated at 96.7% (58 of 60 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/
Currently translated at 96.6% (57 of 59 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Currently translated at 96.6% (57 of 59 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
Negative tax line in supplier invoice, must be negative in vat register line
Currently translated at 98.3% (58 of 59 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_vat_registries
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_vat_registries/it/
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

l10n_it_vat_registries/models/vat_registry.py Outdated Show resolved Hide resolved
<field name="type_tax_use" position="after">
<field name="exclude_from_registries" />
<field
name="cee_type"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chissà se questo campo è effettivamente ancora usato da qualcuno. Si potrebbe fare un sondaggio ed eventualmente rimuoverlo.
Lo scrivo solo come appunto, non bloccante per la PR

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_vat_registries branch 2 times, most recently from 5f2c597 to b84d01e Compare July 19, 2023 14:48
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbtechnology
Copy link

C'è qualche altra cosa che è bloccante per la PR?

@tafaRU
Copy link
Member

tafaRU commented Aug 25, 2023

@eLBati puoi aggiornare la tua review?

Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Potresti modificare la storia dei commit come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests?

l10n_it_vat_registries/i18n/it.po Outdated Show resolved Hide resolved
l10n_it_vat_registries/tests/test_registry.py Outdated Show resolved Hide resolved
l10n_it_vat_registries/wizard/print_registro_iva.py Outdated Show resolved Hide resolved
@andreampiovesana
Copy link
Contributor

merge @eLBati ?

@michelerusti
Copy link
Contributor

michelerusti commented Sep 7, 2023

prendo in carico la PR
#3560

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_vat_registries branch from b84d01e to e80a231 Compare September 7, 2023 10:20
@Borruso Borruso requested a review from SirAionTech September 7, 2023 10:21
Copy link
Contributor

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok . test funzionali ok anche con le varie richieste fatte.

Copy link

@newneo47 newneo47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok test

@SirAionTech
Copy link
Contributor

Prendo in carico per fare le modifiche mancanti

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_vat_registries branch 2 times, most recently from 7bd93bc to 04fd29a Compare September 7, 2023 14:22
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_vat_registries branch from 04fd29a to 9694c33 Compare September 7, 2023 14:32
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sostituita da #3564

@tafaRU tafaRU closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.