Skip to content

Commit

Permalink
[FIX][14.0] assets_management do not report assets sold before report…
Browse files Browse the repository at this point in the history
… date
  • Loading branch information
sergiocorato committed Aug 22, 2023
1 parent a067baa commit 345f630
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 0 deletions.
7 changes: 7 additions & 0 deletions assets_management/report/asset_journal.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class Report(models.TransientModel):
show_totals = fields.Boolean()

show_category_totals = fields.Boolean()
show_sold_assets = fields.Boolean()

type_ids = fields.Many2many(
"asset.depreciation.type",
Expand Down Expand Up @@ -288,6 +289,12 @@ def get_depreciations(self):
domain += [("date_start", "<=", self.date)]
if self.type_ids:
domain += [("type_id", "in", self.type_ids.ids)]
if not self.show_sold_assets:
domain += [
"|",
("asset_id.sale_date", "=", False),
("asset_id.sale_date", ">=", self.date.replace(month=1, day=1)),
]
return self.env["asset.depreciation"].search(domain)

def set_report_name(self):
Expand Down
7 changes: 7 additions & 0 deletions assets_management/report/asset_previsional.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class Report(models.TransientModel):
show_totals = fields.Boolean()

show_category_totals = fields.Boolean()
show_sold_assets = fields.Boolean()

type_ids = fields.Many2many(
"asset.depreciation.type",
Expand Down Expand Up @@ -317,6 +318,12 @@ def get_assets(self):
domain += [("company_id", "=", self.company_id.id)]
if self.date:
domain += [("purchase_date", "<=", self.date)]
if not self.show_sold_assets:
domain += [
"|",
("sale_date", "=", False),
("sale_date", ">=", self.date.replace(month=1, day=1)),
]
return self.env["asset.asset"].search(domain)

def set_report_name(self):
Expand Down
5 changes: 5 additions & 0 deletions assets_management/report/templates/asset_journal.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
<h1 style="text-align:center;">
<span t-field="o.report_name" />
</h1>
<t t-if="o.show_sold_assets">
<div style="width: 100%; text-align:center;">
Sold assets: show
</div>
</t>
</div>
</template>

Expand Down
5 changes: 5 additions & 0 deletions assets_management/report/templates/asset_previsional.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
<h1 style="text-align:center;">
<span t-field="o.report_name" />
</h1>
<t t-if="o.show_sold_assets">
<div style="width: 100%; text-align:center;">
Sold assets: show
</div>
</t>
</div>
</template>

Expand Down
6 changes: 6 additions & 0 deletions assets_management/wizard/asset_journal_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ def get_default_type_ids(self):
show_totals = fields.Boolean(default=True, string="Show Totals")

show_category_totals = fields.Boolean(default=True, string="Show Category Totals")
show_sold_assets = fields.Boolean(
help="By default, only unsold or assets sold in the selected year are printed."
"\nBy selecting this flag, the report will show all assets, ignoring the sold "
"check."
)

report_footer_year = fields.Char(
default=get_default_report_footer_year, string="Report Footer Year"
Expand Down Expand Up @@ -152,6 +157,7 @@ def prepare_report_vals(self):
"date": self.date,
"show_totals": self.show_totals,
"show_category_totals": self.show_category_totals,
"show_sold_assets": self.show_sold_assets,
"report_footer_year": self.report_footer_year,
"type_ids": [(6, 0, self.type_ids.ids)],
}
1 change: 1 addition & 0 deletions assets_management/wizard/asset_journal_report_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<group>
<field name="show_totals" />
<field name="show_category_totals" />
<field name="show_sold_assets" />
</group>
</group>
<group name="report_options" string="Options">
Expand Down
6 changes: 6 additions & 0 deletions assets_management/wizard/asset_previsional_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ def get_default_type_ids(self):
show_totals = fields.Boolean(default=True, string="Show Totals")

show_category_totals = fields.Boolean(default=True, string="Show Category Totals")
show_sold_assets = fields.Boolean(
help="By default, only unsold or assets sold in the selected year are printed."
"\nBy selecting this flag, the report will show all assets, ignoring the sold "
"check."
)

report_footer_year = fields.Char(
default=get_default_report_footer_year, string="Report Footer Year"
Expand Down Expand Up @@ -152,6 +157,7 @@ def prepare_report_vals(self):
"date": self.date,
"show_totals": self.show_totals,
"show_category_totals": self.show_category_totals,
"show_sold_assets": self.show_sold_assets,
"report_footer_year": self.report_footer_year,
"type_ids": [(6, 0, self.type_ids.ids)],
}
1 change: 1 addition & 0 deletions assets_management/wizard/asset_previsional_report_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
<group>
<field name="show_totals" />
<field name="show_category_totals" />
<field name="show_sold_assets" />
</group>
</group>
<group name="report_options" string="Options">
Expand Down

0 comments on commit 345f630

Please sign in to comment.