[17.0][MIG] hr_holidays_settings: Migration to 17.0 #154

peluko00 · 2024-12-09T16:43:11Z

Module migrated to version 17.0

cc https://github.com/APSL 164504
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko please review

[Issue] Migration to version 17.0 #95

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/fa/

Currently translated at 100,0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/pt_BR/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/es/

Currently translated at 75.0% (3 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/fr/

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/de/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/

Currently translated at 100.0% (3 of 3 strings) Translation: hr-holidays-13.0/hr-holidays-13.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-13-0/hr-holidays-13-0-hr_holidays_settings/ca/

Currently translated at 100.0% (3 of 3 strings) Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_settings/it/

BernatObrador

There are a few things happening in this migration:

Missing Image in v17
v16:

v17:

There is no image in de v17.

Missing Title in v17
v16

The title displayed in v16 does not appear in v17, leaving the page blank.

Error When Navigating Between Settings Pages

An error occurs if you try to navigate to Leaves Management from another settings page (e.g., General Settings). The following error is raised:
OwlError: Invalid props for component 'SettingsBlock': 'slots' is missing (should be a object) Error: Invalid props for component 'SettingsBlock': 'slots' is missing (should be a object) at Object.validateProps (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1143:67) at SettingsFormRenderer.slot92 (eval at compile (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1511:421), <anonymous>:1291:13) at callSlot (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1110:25) at SettingsApp.template (eval at compile (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1511:421), <anonymous>:23:12) at Fiber._render (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:940:96) at Fiber.render (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:939:6) at ComponentNode.updateAndRender (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1029:29)

peluko00 · 2024-12-10T09:25:15Z

There are a few things happening in this migration:

Missing Image in v17
v16:

v17:

There is no image in de v17.

Missing Title in v17
v16

The title displayed in v16 does not appear in v17, leaving the page blank.

Error When Navigating Between Settings Pages

An error occurs if you try to navigate to Leaves Management from another settings page (e.g., General Settings). The following error is raised: OwlError: Invalid props for component 'SettingsBlock': 'slots' is missing (should be a object) Error: Invalid props for component 'SettingsBlock': 'slots' is missing (should be a object) at Object.validateProps (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1143:67) at SettingsFormRenderer.slot92 (eval at compile (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1511:421), <anonymous>:1291:13) at callSlot (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1110:25) at SettingsApp.template (eval at compile (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1511:421), <anonymous>:23:12) at Fiber._render (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:940:96) at Fiber.render (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:939:6) at ComponentNode.updateAndRender (http://oca-hr-holidays-17-0-pr154-dc44004b8f00.runboat.odoo-community.org/web/assets/8a10801/web.assets_web.min.js:1029:29)

Fixed. Thanks for the comments!

BernatObrador

LGTM!

DucTruongKomit

Review done. LGTM

mpascuall

LGTM, tested in runboat

ppyczko

LGTM

OCA-git-bot · 2024-12-14T17:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

MiquelRForgeFlow and others added 30 commits December 9, 2024 17:20

[10.0][ADD] hr_holidays_settings

d2b32a3

[FIX] add company_id in view

91ae9cf

[FIX][hr_holidays_settings] Make 'Leave Types' view accessible (#408)

a6cc613

OCA Transbot updated translations from Transifex

7213273

OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex

[MIG] hr_holidays_settings: Migration to 11.0

ea1cfa8

OCA Transbot updated translations from Transifex

b603a79

[UPD] Update hr_holidays_settings.pot

583cdb4

Translated using Weblate (Persian)

6f257db

Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/fa/

Translated using Weblate (Portuguese (Brazil))

b808cb4

Currently translated at 100,0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_settings/pt_BR/

[MIG] hr_holidays_settings: Migration to 12.0.

8a40eda

[UPD] README.rst

2b34c65

[UPD] Update hr_holidays_settings.pot

ea89706

Update translation files

4a61c9c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/

Translated using Weblate (Spanish)

25efb04

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/es/

Translated using Weblate (French)

69c7736

Currently translated at 75.0% (3 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/fr/

Translated using Weblate (German)

e616cbb

Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/de/

[UPD] README.rst

3ad4389

[FIX] hr_holidays_settings: duplicate Leave Types menuitem

30e45f4

[UPD] Update hr_holidays_settings.pot

1b493c0

[UPD] README.rst

d0f51e5

hr_holidays_settings 12.0.1.1.0

44e5160

Update translation files

0db0a71

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_settings/

[MIG] hr_holidays_settings: Migration to 13.0

aa482ea

[UPD] Update hr_holidays_settings.pot

abea52e

[UPD] README.rst

b2c6916

[UPD] README.rst

68108e5

Added translation using Weblate (Catalan)

e5e96c3

Translated using Weblate (Catalan)

08acda9

Currently translated at 100.0% (3 of 3 strings) Translation: hr-holidays-13.0/hr-holidays-13.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-13-0/hr-holidays-13-0-hr_holidays_settings/ca/

pre-commit update

ca69917

[UPD] Eficent -> ForgeFlow

0c550ed

OCA-git-bot and others added 14 commits December 9, 2024 17:20

[UPD] README.rst

07bb864

[UPD] Brainbean Apps => CorporateHub

e09d234

[UPD] README.rst

a98739d

[IMP] *: pre-commit run

a349a78

[MIG] hr_holidays_settings: Migration to 14.0

4e0e17f

[UPD] Update hr_holidays_settings.pot

630782c

[UPD] README.rst

626f81b

Translated using Weblate (Italian)

cb9eaac

Currently translated at 100.0% (3 of 3 strings) Translation: hr-holidays-14.0/hr-holidays-14.0-hr_holidays_settings Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-14-0/hr-holidays-14-0-hr_holidays_settings/it/

[UPD] README.rst

7471d58

[MIG] hr_holidays_settings: Migration to 15.0

99404b7

[MIG] hr_holidays_settings: Migration to 16.0

83c654a

[UPD] Update hr_holidays_settings.pot

ca89199

[BOT] post-merge updates

006cee0

[IMP] hr_holidays_settings: pre-commit auto fixes

6e3b3f8

peluko00 mentioned this pull request Dec 9, 2024

Migration to version 17.0 #95

Open

4 tasks

BernatObrador reviewed Dec 10, 2024

View reviewed changes

[MIG] hr_holidays_settings: Migration to 17.0

8cfd782

peluko00 force-pushed the 17.0-mig-hr_holidays_settings branch from dc44004 to 8cfd782 Compare December 10, 2024 09:21

BernatObrador approved these changes Dec 11, 2024

View reviewed changes

DucTruongKomit approved these changes Dec 11, 2024

View reviewed changes

OCA-git-bot added the approved label Dec 11, 2024

mpascuall approved these changes Dec 11, 2024

View reviewed changes

ppyczko approved these changes Dec 11, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Dec 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] hr_holidays_settings: Migration to 17.0 #154

[17.0][MIG] hr_holidays_settings: Migration to 17.0 #154

peluko00 commented Dec 9, 2024

BernatObrador left a comment

peluko00 commented Dec 10, 2024

BernatObrador left a comment

DucTruongKomit left a comment

mpascuall left a comment

ppyczko left a comment

OCA-git-bot commented Dec 14, 2024

[17.0][MIG] hr_holidays_settings: Migration to 17.0 #154

Are you sure you want to change the base?

[17.0][MIG] hr_holidays_settings: Migration to 17.0 #154

Conversation

peluko00 commented Dec 9, 2024

BernatObrador left a comment

Choose a reason for hiding this comment

peluko00 commented Dec 10, 2024

BernatObrador left a comment

Choose a reason for hiding this comment

DucTruongKomit left a comment

Choose a reason for hiding this comment

mpascuall left a comment

Choose a reason for hiding this comment

ppyczko left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 14, 2024