Skip to content

[19.0][MIG] sale_crm_event_reservation: Migration to version 19.0 - #546

Merged
OCA-git-bot merged 17 commits into
OCA:19.0from
Tecnativa:19.0-mig-sale_crm_event_reservation
Aug 18, 2026
Merged

[19.0][MIG] sale_crm_event_reservation: Migration to version 19.0#546
OCA-git-bot merged 17 commits into
OCA:19.0from
Tecnativa:19.0-mig-sale_crm_event_reservation

Conversation

@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

Jairo Llopis and others added 7 commits August 18, 2026 12:26
This module extends the functionality of *crm_event*, *event_sale_reservation*
and *sale_crm* to support fast generation of event quotations from
opportunities and to allow you to sell events like a boss.

@Tecnativa TT27664

[UPD] Update sale_crm_event_reservation.pot

[UPD] README.rst
For complying with manifestoo requirements.
@OCA-git-bot OCA-git-bot added series:19.0 mod:sale_crm_event_reservation Module sale_crm_event_reservation labels Aug 18, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration sale_crm_event_reservation

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Aug 18, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 18, 2026
27 tasks
Comment thread sale_crm_event_reservation/__manifest__.py Outdated
Comment thread sale_crm_event_reservation/wizards/crm_lead_event_sale_wizard_views.xml Outdated
Comment thread sale_crm_event_reservation/tests/test_wizard.py
Comment thread sale_crm_event_reservation/tests/test_wizard.py
@carlos-lopez-tecnativa

Copy link
Copy Markdown

Additionally, could you squash the administrative commits?

mymage and others added 10 commits August 18, 2026 15:09
Currently translated at 100.0% (26 of 26 strings)

Translation: event-15.0/event-15.0-sale_crm_event_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-sale_crm_event_reservation/es/
Currently translated at 100.0% (27 of 27 strings)

Translation: event-17.0/event-17.0-sale_crm_event_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-17-0/event-17-0-sale_crm_event_reservation/it/
…der with Form to respect blocks

Manage partner blocking when creating orders with Form, redirecting to
standard action if there is no partner.
Order creation with Form is maintained and partner blocking is handled
with conditional redirection to ensure that order lines are created
correctly and all associated logic is executed, which does not happen
if the standard action `action_new_quotation` is used, which only
creates the order without lines.
However, when using `Form`, if the contact has a blocking message that
prevents the partner from being assigned, order creation fails with a
required field error. To avoid this, a conditional is added that detects
if the partner could not be assigned in the form, and in that case, it
redirects to the standard action `action_new_quotation`, passing the
partner via context (`default_partner_id`) so that the blocking message
is displayed normally, respecting the Odoo flow.
This achieves the following:
- Create the order with lines correctly when possible.
- Display the partner block if necessary without throwing errors.
- Do not lose the basic Odoo validation.
Don't compare a date with a datetime field:

```
File "/opt/odoo/auto/addons/sale_crm_event_reservation/wizards/crm_lead_event_sale_wizard.py", line 96, in <lambda>
  or ticket.end_sale_datetime >= fields.Date.context_today(self)
TypeError: can't compare datetime.datetime to datetime.date
```

TT57560
@pilarvargas-tecnativa
pilarvargas-tecnativa force-pushed the 19.0-mig-sale_crm_event_reservation branch from 19ab7c4 to 9cb953a Compare August 18, 2026 13:09

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victoralmau victoralmau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-546-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 40e1a9b into OCA:19.0 Aug 18, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at e74da6a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 19.0-mig-sale_crm_event_reservation branch August 18, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants