[19.0][FIX] event_sale_reservation: Compatibility with sale_project - #543
Merged
Merged
Conversation
Contributor
|
Hi @pilarvargas-tecnativa, |
OCA-git-bot
added
series:19.0
mod:event_sale_reservation
pedrobaeza
approved these changes
Aug 14, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
I don't see side effects on this, as if sale_project compute is called first, then you overwrite later, and if it's called later, as you are not including the affected records in super, they are not modified.
carlos-lopez-tecnativa
force-pushed
the
19.0-fix-event_sale_reservation
branch
from
August 17, 2026 12:13
ead016b to
b46a80a
Compare
The sale_project module overrides _compute_product_updatable and sets it to False when the product is a service and the sale order is confirmed. When a product created for an event reservation is a service and the sale order is confirmed, an error is raised when trying to register for the event, indicating that the product cannot be changed on the sale order line. As there is no explicit dependency on sale_project, the sale_project method is called first. Steps to reproduce: Create a sale order with a product for reservation. Confirm the order. Click Register in event. Select the event and click Next. The error is displayed.
carlos-lopez-tecnativa
force-pushed
the
19.0-fix-event_sale_reservation
branch
from
August 17, 2026 12:18
b46a80a to
f7c0564
Compare
carlos-lopez-tecnativa
marked this pull request as ready for review
August 17, 2026 12:18
BhaveshHeliconia
approved these changes
Aug 19, 2026
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 7f515fb. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sale_projectmodule overrides _compute_product_updatable and sets it toFalsewhen the product is aserviceand the sale order isconfirmed.When a product created for an event reservation is a service and the sale order is confirmed, an error is raised when trying to register for the event, indicating that the product cannot be changed on the sale order line.
As there is no explicit dependency on sale_project, the sale_project method is called first.
Steps to reproduce:
Create a sale order with a product for reservation. Confirm the order.
Click Register in event.
Select the event and click Next.
The error is displayed.
@Tecnativa @pedrobaeza @pilarvargas-tecnativa could you please review this?