[16.0][ADD] website_sale_commitment_date #1004
Conversation
adasatorres
force-pushed
the
16.0-add-website_sale_commitment_date
branch
4 times, most recently
from
66af92e to
c03219e
Compare
|
To use this addon, you need to go to the shipping method and activate the "allow commitment date" option. |
| lang = request.env["res.lang"]._lang_get( | ||
| request.env.context.get("lang", False) or request.env.user.lang | ||
| ) | ||
| if order: | ||
| date_obj = datetime.strptime( | ||
| string_date, | ||
| lang.date_format if lang else DEFAULT_SERVER_DATE_FORMAT, |
There was a problem hiding this comment.
Perhaps you can use "from odoo.tools.misc import format_date" to the date manipulation according to language and encapsulate this behavior in a separated auxiliary method to reuse below too.
There was a problem hiding this comment.
Hi @rrebollo, I believe that format_date cannot be used to create a date object from a string.
There was a problem hiding this comment.
Of course, my suggestion implicitly mean to do some refactoring around to rely upon odoo's built-in wrappers to work with python dates. But it was only a suggestion. Again, great work
| def _compute_name(self): | ||
| for record in self: | ||
| if record.value: | ||
| record.name = record.value.strftime("%d/%m/%Y") |
There was a problem hiding this comment.
Why ""%d/%m/%Y" as format? Wouldn't "%Y/%m/%d" be "safer" instead?
There was a problem hiding this comment.
Hi @rrebollo, I could use the date format provided by the language, so the format will be created based on the user's language.
There was a problem hiding this comment.
Yes that'll be a better approach in deed
adasatorres
force-pushed
the
16.0-add-website_sale_commitment_date
branch
from
c03219e to
51a9269
Compare
Hi, this addon allows selecting the delivery date when purchasing from the e-commerce platform, configuring excluded days of the week, minimum or maximum days to limit the selection
from the current date. All of this is configurable from the shipping method.