[16.0][MIG] contract_sale: Migration to 16.0 #915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* README by fragments * Adjusted dependency * Changed root menu XML-ID
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/gl/
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/zh_CN/
[FIX] - fix flake8
[REF] Contract Sale: update translations
The lowest model access for contract.contract model is group_account_invoice group. However the addon adds two smart buttons to res.partner view without any security restrictions and without compute_sudo attribute on computed fields. This causes the view to crash when a user without the proper permissions tries to access the res.partner form view. The solution adds groups_id to the partner form views in which the buttons are added, so the only loads when the user has proper permissions. Other way to solve it would be to add compute_sudo attribute to the relevant fields, but this causes an access error when the user clicks on the smart buttons.
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
Currently translated at 100.0% (1 of 1 strings) Translation: contract-12.0/contract-12.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_sale/es_CL/
Currently translated at 100.0% (1 of 1 strings) Translation: contract-14.0/contract-14.0-contract_sale Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale/es_AR/
…ce: from contract_sale to contract
|
Maybe test cases fail because of the contract module dependency, we have open PR of the contract module #887 if we merge first then test cases fails is solved |
pedrobaeza
changed the title
|
Please rebase to see the proper CI status. |
|
@urvisha-serpentcs Do you mind if we switch to #949 ? |
|
@rousseldenis you can switch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.