Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig contract sale generation #914

Closed
wants to merge 62 commits into from

Conversation

vibhascs
Copy link

No description provided.

Copy link

@NotJaime13 NotJaime13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funtional review ok!

@rousseldenis
Copy link
Contributor

/ocabot migration contract_sale_generation

@rousseldenis
Copy link
Contributor

/ocabot rebase

@rousseldenis
Copy link
Contributor

@vibhascs Could you follow migration guide, especially Full process part as some changes should appear in pre-commit stuff commit ? Thanks

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 21, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 21, 2023
14 tasks
angelmoya and others added 22 commits March 21, 2023 09:16
…ata (OCA#130)

* [FIX+IMP] contract: Improve usability and don't fail on wrong data

* Cron create invoices masked for avoiding silent errors
* New constraints for assuring data consistency
* UI helps for entering consistent data
* Spanish translation
* Remove double company_id field on form

* [FIX] contract_sale_generation: Adapt tests to upstream contract
* Change the method called in the view
* Complete the create_invoice method
* Bump version + authoring
* Correct bad call of method
  Small Documentation
* Add super call in python test
* FIX bad field names causing bad quantities in sale.order.line
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-10.0/contract-10.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/gl/
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-10.0/contract-10.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-10-0/contract-10-0-contract_sale_generation/de/
rousseldenis and others added 22 commits March 21, 2023 09:16
Currently translated at 100.0% (15 of 15 strings)

Translation: contract-14.0/contract-14.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/es_AR/
…fter generation on contract level

As in contract module, recompute recurring_next_date after sale generation on contract level
Currently translated at 100.0% (15 of 15 strings)

Translation: contract-14.0/contract-14.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/ca/
Currently translated at 73.3% (11 of 15 strings)

Translation: contract-14.0/contract-14.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/it/
Currently translated at 93.3% (14 of 15 strings)

Translation: contract-14.0/contract-14.0-contract_sale_generation
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_sale_generation/it/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-MIG-contract_sale_generation branch from 24fd0fd to 3c9ebbe Compare March 21, 2023 09:16
Copy link

@manuelcalerosolis manuelcalerosolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funtional review ok!

@rousseldenis
Copy link
Contributor

@vibhascs Do you mind if we switch to #955 ?

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@github-actions github-actions bot closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.