[17.0][FIX] contract: Malformed expression in the column_invisible attribute. #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-RB
approved these changes
Feb 13, 2025
adasatorres
force-pushed
the
17.0-fix-contract
branch
from
0851e31 to
1c0f569
Compare
pedrobaeza
reviewed
Feb 13, 2025
contract/views/contract_template.xml
Outdated
| <p> <strong>#END#</strong>: End date of the invoiced period</p> | ||
| <p> <strong | ||
| >#INVOICEMONTHNAME#</strong>: Invoice month name of the invoiced period</p> | ||
| <p> |
There was a problem hiding this comment.
Avoid these changes that are not related
There was a problem hiding this comment.
I know, but I have an extension in the VS code that pre-formats when I save the changes.
There was a problem hiding this comment.
Well, deactivate it for contributing to OCA, please. Undo this change and I think it's OK.
adasatorres
force-pushed
the
17.0-fix-contract
branch
from
1c0f569 to
ee8a15b
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 55eac65. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good morning, we have identified an error when creating a contract template for suppliers. This error occurs because the following Python expression is being evaluated in a
column_invisibleattribute.parent.contract_type == 'purchase' and not is_auto_renewAccording to the Odoo documentation (https://github.com/odoo/documentation/blob/8f1d5d428c2bbb6f420577d02c28d5eef7678096/content/developer/reference/user_interface/view_architectures/generic_attribute_column_invisible.rst), I understand that in these cases, it is not possible to use the values from the tree in the expression. Instead, one must use the values from the parent or a value from the context.
I’m attaching a screenshot of the error.
