[17.0][FIX] product_contract: Compute date_start from the current date instead of date_order #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of date_order This commit standardizes date_start across methods, ensuring it is set to the current date instead of date_order. If a user adds a new line after confirming the order (several days or months later), date_start would otherwise be outdated.
|
Hi @sbejaoui, |
pedrobaeza
reviewed
Feb 4, 2025
There was a problem hiding this comment.
I didn't remember all the compute thing, but my idea was not to have this field pre-computed, but calculated when confirming the sales order. Why it's pre-filled if you don't know when the order is going to be confirmed? @sergio-teruel you did the change. What was your goal with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit standardizes
date_startacross methods, ensuring it is set to the current date instead of date_order. If a user adds a new line after confirming the order (several days or months later),date_startwould otherwise be outdated.TT54892
@Tecnativa @pedrobaeza @sergio-teruel @CarlosRoca13 Could you please review this