Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] subscription_oca: Various improvements #1058

Merged
merged 1 commit into from
Mar 16, 2025
Merged

[16.0][IMP] subscription_oca: Various improvements #1058

merged 1 commit into from
Mar 16, 2025

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Mar 14, 2024

Fixes improvements mentioned here: #1057

@tarteo tarteo force-pushed the 16-imp-subscription_oca branch from 8473c8f to 3851561 Compare March 14, 2024 11:13
@tarteo
Copy link
Member Author

tarteo commented Mar 14, 2024 •
edited
Loading

Not sure why the codecov/patch check is failing because codecov says there's a positive change (+0.03%)

image

@tarteo tarteo mentioned this pull request Mar 15, 2024
Merged
@tarteo tarteo changed the title [IMP] subscription_oca: Various improvements [16.0][IMP] subscription_oca: Various improvements Mar 15, 2024
@flotho flotho mentioned this pull request Jul 6, 2024
Closed
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 28, 2024
@pedrobaeza pedrobaeza mentioned this pull request Aug 1, 2024
Open
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@max3903 max3903 added this to the 16.0 milestone Sep 23, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 26, 2025
@tarteo tarteo force-pushed the 16-imp-subscription_oca branch 3 times, most recently from 55e00fa to 37f5066 Compare January 28, 2025 11:15
@tarteo
Copy link
Member Author

tarteo commented Jan 28, 2025

@OCA/community-maintainers There's no team for contract maintainers. Can anyone decide if this can be merged or not, please. Codecov is failing but I don't know how I can increase test coverage in a meaningful way without creating bs tests.

@simahawk
Copy link

@OCA/project-service-maintainers 😉

@tarteo
Copy link
Member Author

tarteo commented Jan 28, 2025

@simahawk Ah thanks! 😄

rousseldenis
rousseldenis approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

Seems great

@tarteo
Copy link
Member Author

tarteo commented Jan 29, 2025

@rousseldenis Thanks! I will look this week on how to extend the tests (in a meaningful way) to cover more code.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
@tarteo tarteo force-pushed the 16-imp-subscription_oca branch 5 times, most recently from 82b7c96 to 1df9716 Compare February 6, 2025 15:04
@tarteo tarteo force-pushed the 16-imp-subscription_oca branch from 1df9716 to d92d2d3 Compare February 6, 2025 15:16
ByteMeAsap
ByteMeAsap approved these changes Feb 7, 2025
View reviewed changes
Copy link

@ByteMeAsap ByteMeAsap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tarteo
Copy link
Member Author

tarteo commented Feb 21, 2025

@rousseldenis @OCA/project-service-maintainers Can we please merge this? Let me know

@rousseldenis
Copy link
Contributor

@tarteo Could you squash the merge commit ? Thanks

@tarteo tarteo force-pushed the 16-imp-subscription_oca branch 3 times, most recently from d92d2d3 to 585a4bb Compare March 12, 2025 13:18
@tarteo
[IMP] subscription_oca: Various improvements
e03cded 
oca_subscription: Open subscription button in invoice view
oca_subscription: Use close_subscription
oca_subscription: Extra test to cover false condition
oca_subscription: Test if it logs something if the cron fails
@tarteo tarteo force-pushed the 16-imp-subscription_oca branch from 585a4bb to e03cded Compare March 12, 2025 13:26
@tarteo
Copy link
Member Author

tarteo commented Mar 12, 2025

@rousseldenis Fixed it :)

@dreispt
Copy link
Member

dreispt commented Mar 16, 2025

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1058-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7692fa2 into OCA:16.0 Mar 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 158cbe4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrito gbrito gbrito approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@ByteMeAsap ByteMeAsap ByteMeAsap approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tarteo @simahawk @OCA-git-bot @rousseldenis @dreispt @gbrito @ByteMeAsap @max3903