[FIX] Added more dependend fields for some compute methods as mention…

…ed by @DucTruongKomit. Small UI fix.
OCA · Feb 27, 2023 · 3cfdd0d · 3cfdd0d
1 parent 1aaa235
commit 3cfdd0d
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 13 deletions.
diff --git a/contract/models/contract_line.py b/contract/models/contract_line.py
@@ -105,7 +105,11 @@ class ContractLine(models.Model):
     )
 
     @api.depends(
-        "last_date_invoiced", "date_start", "date_end", "contract_id.last_date_invoiced"
+        "last_date_invoiced",
+        "date_start",
+        "date_end",
+        "contract_id.last_date_invoiced",
+        "contract_id.contract_line_ids.last_date_invoiced",
     )
     # pylint: disable=missing-return
     def _compute_next_period_date_start(self):
@@ -145,7 +149,15 @@ def _compute_termination_notice_date(self):
             else:
                 rec.termination_notice_date = False
 
-    @api.depends("is_canceled", "date_start", "date_end", "is_auto_renew")
+    @api.depends(
+        "is_canceled",
+        "date_start",
+        "date_end",
+        "is_auto_renew",
+        "manual_renew_needed",
+        "termination_notice_date",
+        "successor_contract_line_id",
+    )
     def _compute_state(self):
         today = fields.Date.context_today(self)
         for rec in self:

diff --git a/contract/models/contract_modification.py b/contract/models/contract_modification.py
@@ -19,7 +19,7 @@ class ContractModification(models.Model):
         ondelete="cascade",
         index=True,
     )
-    sent = fields.Boolean(default=False)
+    sent = fields.Boolean()
 
     @api.model_create_multi
     def create(self, vals_list):

diff --git a/contract/views/abstract_contract_line.xml b/contract/views/abstract_contract_line.xml
@@ -14,16 +14,13 @@
                     <field name="specific_price" invisible="1" />
                     <field name="currency_id" invisible="1" />
                     <field colspan="1" name="product_uom_category_id" invisible="1" />
-                    <label
-                        for="product_id"
-                        attrs="{'invisible': [('display_type', '!=', False)]}"
-                    />
-                    <field
-                        colspan="1"
-                        name="product_id"
-                        attrs="{'required': [('display_type', '=', 'product')],'invisible': [('display_type', '!=', False)]}"
-                        nolabel="1"
-                    />
+                    <group>
+                        <field
+                            colspan="1"
+                            name="product_id"
+                            attrs="{'required': [('display_type', '=', 'product')],'invisible': [('display_type', '!=', False)]}"
+                        />
+                    </group>
                     <group
                         col="6"
                         attrs="{'invisible': [('display_type', '!=', False)]}"