Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] account_cash_discount_payment #604

Merged

Conversation

geomer198
Copy link
Contributor

@geomer198 geomer198 commented Mar 5, 2023

Fixed dependencies in account_cash_discount_payment module as it caused issues in account_cash_discount_write_off tests in PRs: #589, #431, #578, #605.

@Aldeigja
Copy link
Contributor

Aldeigja commented Mar 7, 2023

@OCA/banking-maintainers could you take a look?

@francesco-ooops
Copy link
Contributor

@pedrobaeza could you please review?

we need this for #617 as well

Thanks!

@francesco-ooops
Copy link
Contributor

@OCA/banking-maintainers gentle reminder

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@etobella could you help us fix tests for this repo by merging this PR? Thank you!

@etobella
Copy link
Member

etobella commented Apr 6, 2023

Well, I would prefer to understand the change of dependencies... It seems too hard IMO. Didn't you found a way to fix tests directly?

@francesco-ooops
Copy link
Contributor

@geomer198 could you check?

@geomer198
Copy link
Contributor Author

@etobella Thanks for your question.
The functions and fields, that are used in this module are in the module account_payment_order_grouped_output module
So I think the best solution here is to change the dependencies instead of fixing the tests.

@etobella
Copy link
Member

etobella commented Apr 6, 2023

I see...
/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-604-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e0aae69 into OCA:14.0 Apr 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4ff5edf. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants