-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][FIX] account_cash_discount_payment #604
[14.0][FIX] account_cash_discount_payment #604
Conversation
@OCA/banking-maintainers could you take a look? |
@pedrobaeza could you please review? we need this for #617 as well Thanks! |
@OCA/banking-maintainers gentle reminder |
This PR has the |
@etobella could you help us fix tests for this repo by merging this PR? Thank you! |
Well, I would prefer to understand the change of dependencies... It seems too hard IMO. Didn't you found a way to fix tests directly? |
@geomer198 could you check? |
@etobella Thanks for your question. |
I see... |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 4ff5edf. Thanks a lot for contributing to OCA. ❤️ |
Fixed dependencies in account_cash_discount_payment module as it caused issues in account_cash_discount_write_off tests in PRs: #589, #431, #578, #605.