Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18][MIG] sale_line_refund_to_invoice_qty #1903

Open
wants to merge 22 commits into
base: 18.0
Choose a base branch
from

Conversation

florian-dacosta
Copy link

This migration from v16 include #1748 that was not ported from 14 to 16.

I also made 2 changes :

  • Hide the sale_qty_to_reinvoice field if the refund is not linked to an invoice.
    It was quite strange to see this "Sale Qty To Reinvoice" checked for refund created manually or from an other source (RMA...). And it does nothing if no sale is linked.
  • Take the company configuration in the default of the field. It was also confusin IMO to have the field checked by default when it was deactivated on the company configuration

@PicchiSeba Could you have a look at the change on default to see if you agree since it kind of completes your addition ?

@JordiMForgeFlow @LoisRForgeFlow @rousseldenis It could interests you I guess

JordiMForgeFlow and others added 22 commits February 7, 2025 09:39
…tion for usability and only display on credit notes
when you mark a refund to not be reinvoiced, the invoice qty
should not be reduced, because it is already invoiced and you
won't invoice it again.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-sale_line_refund_to_invoice_qty
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-sale_line_refund_to_invoice_qty/
Currently translated at 100.0% (10 of 10 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-sale_line_refund_to_invoice_qty
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-sale_line_refund_to_invoice_qty/fr/
Currently translated at 100.0% (10 of 10 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-sale_line_refund_to_invoice_qty
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-sale_line_refund_to_invoice_qty/it/
As Odoo initializes default values on records by an update on all existing ones,
this can take a great amount of time. Instead, use sql default value at column
creation.
add setting for default value in credit note wizard
Also take the company parameter in the default of the refund line
@rousseldenis
Copy link
Contributor

  • It was quite strange to see this "Sale Qty To Reinvoice" checked for refund created manually or from an other source (RMA...). And it does nothing if no sale is linked.

@florian-dacosta That's because this is the standard Odoo behavior. It is intended to not change that.

If people don't want to reinvoice, uncheck the box

@florian-dacosta
Copy link
Author

  • It was quite strange to see this "Sale Qty To Reinvoice" checked for refund created manually or from an other source (RMA...). And it does nothing if no sale is linked.

@florian-dacosta That's because this is the standard Odoo behavior. It is intended to not change that.

If people don't want to reinvoice, uncheck the box

I know it is standard behavior, but this behavior exists only for refund linked to sale orders.
So if your refund is not linked to a sale order, this box does not do anything. Then, it is confusing for user to have some option checked, that say it will be re-invoiced when it does not has any effect anywhere right ?
Does it seem right/do you agree to hide it anyway in this case ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.