[17.0][MIG] stock_picking_invoicing: Migration to 17.0

[Abranes]

Standard migration to 17.0

[Abranes]

Hello, I'm trying to fix the test issue but couldn't identify the exact problem. It seems to stem from the demo data not being installed, as I received this warning:

WARNING stock_picking_invoicing odoo.modules.loading: Module stock_picking_invoicing demo data failed to install, installed without demo data 
Traceback (most recent call last):
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 556, in _tag_root
    f(rec)
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 456, in _tag_record
    record = model._load_records([data], self.mode == 'update')
  File "/opt/odoo/src/odoo/odoo/odoo/models.py", line 5048, in _load_records
    data['record']._load_records_write(data['values'])
  File "/opt/odoo/src/odoo/odoo/odoo/models.py", line 4979, in _load_records_write
    self.write(values)
  File "/opt/odoo/src/addons/stock/models/stock_picking.py", line 859, in write
    raise UserError(_("Changing the operation type of this record is forbidden at this point."))
odoo.exceptions.UserError: Changing the operation type of this record is forbidden at this point.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/src/odoo/odoo/odoo/modules/loading.py", line 89, in load_demo
    load_data(env(su=True), idref, mode, kind='demo', package=package)
  File "/opt/odoo/src/odoo/odoo/odoo/modules/loading.py", line 71, in load_data
    tools.convert_file(env, package.name, filename, idref, mode, noupdate, kind)
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 627, in convert_file
    convert_xml_import(env, module, fp, idref, mode, noupdate)
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 693, in convert_xml_import
    obj.parse(doc.getroot())
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 613, in parse
    self._tag_root(de)
  File "/opt/odoo/src/odoo/odoo/odoo/tools/convert.py", line 569, in _tag_root
    raise ParseError('while parsing %s:%s, somewhere inside\n%s' % (
odoo.tools.convert.ParseError: while parsing /opt/odoo/src/addons/stock_picking_invoicing/demo/stock_picking_demo.xml:42, somewhere inside
<record id="stock_picking_invoicing_2" model="stock.picking">
        <field name="partner_id" ref="base.res_partner_2"/>
        <field name="picking_type_id" ref="stock.picking_type_out"/>
        <field name="invoice_state">2binvoiced</field>
        <field name="origin">stock_picking_invoicing demo</field>
        <field name="location_id" ref="stock.stock_location_stock"/>
        <field name="location_dest_id" ref="stock.stock_location_customers"/>
    </record>

I don’t see the reason for the error since the picking_type_id field is set directly in the test data file and not afterward.

Any suggestions would be welcome, thank you.