Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] account_receipt_sale: invoice word occurrences #1690

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

[14.0][FIX] account_receipt_sale: invoice word occurrences #1690

wants to merge 1 commit into from

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Mar 23, 2024 •
edited
Loading

If using receipts, all texts containing "invoice" (buttons, wizard, etc.) will be changed accordingly.

sale_order_receipt

@OCA-git-bot
Copy link
Contributor

Hi @eLBati,
some modules you are maintaining are being modified, check this out!

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Mar 29, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@primes2h
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @primes2h you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@primes2h primes2h force-pushed the 14.0-FIX-account_receipt_sale-invoice_word_occurrences branch from 75e2ff8 to 9f02616 Compare May 20, 2024 09:11
FrancescoBallerini
FrancescoBallerini approved these changes Jun 25, 2024
View reviewed changes
Copy link

@FrancescoBallerini FrancescoBallerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional: LGTM

@primes2h primes2h force-pushed the 14.0-FIX-account_receipt_sale-invoice_word_occurrences branch from 9f02616 to 6067a17 Compare June 25, 2024 15:38
FrancescoBallerini
FrancescoBallerini suggested changes Jul 5, 2024
View reviewed changes
account_receipt_sale/wizard/sale_make_invoice.py


class SaleAdvancePaymentInv(models.TransientModel):
class SaleAdvancePaymentRec(models.TransientModel):
_name = "sale.advance.payment.rec"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergio, is it necessary to re-define a new name for the model? If that's the case could you also add _description attribute? Otherwise it will give annoying warnings in the log during the module update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sergio, is it necessary to re-define a new name for the model? If that's the case could you also add _description attribute? Otherwise it will give annoying warnings in the log during the module update

I'd say yes, _description added here, thanks!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@primes2h primes2h force-pushed the 14.0-FIX-account_receipt_sale-invoice_word_occurrences branch from 6067a17 to 7d62986 Compare July 9, 2024 16:06
@eLBati
Copy link
Member

eLBati commented Jul 12, 2024

Hi @primes2h
did you consider overriding fields_view_get of the involved models to replace strings where needed?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoBallerini FrancescoBallerini FrancescoBallerini approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@primes2h @OCA-git-bot @eLBati @FrancescoBallerini @MaurizioPellegrinet