Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] account_invoice_show_currency_rate: Migration to 17.0 #1689

Open
wants to merge 20 commits into
base: 17.0
Choose a base branch
from

Conversation

jeer2234
Copy link

No description provided.

@jeer2234 jeer2234 mentioned this pull request Mar 20, 2024
46 tasks
@sbidoul
Copy link
Member

sbidoul commented Mar 20, 2024

/ocabot migration account_invoice_show_currency_rate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 20, 2024
@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

victoralmau and others added 18 commits March 20, 2024 19:37
…to avoid many decimal places (1.9974358974358974 for example).
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/es/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/it/
@jeer2234 jeer2234 force-pushed the 17.0-mig-account_invoice_show_currency_rate branch from 19dcd63 to 4286bdb Compare March 20, 2024 23:42
@jeer2234
Copy link
Author

Hello @sbidoul , @pedrobaeza please could you review? 🙏🏼 ❤️

Thank you!

@pedrobaeza
Copy link
Member

You can squash all the migration commits into one. Now, functional/code reviewers should do the reviews. Both Stéphane and me were only reviewers about the form.

@jeer2234 jeer2234 force-pushed the 17.0-mig-account_invoice_show_currency_rate branch from ab4a482 to 89217d8 Compare March 21, 2024 17:01
@jeer2234
Copy link
Author

@victoralmau

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@jeer2234
Copy link
Author

@OCA/core-maintainers

@jeer2234 jeer2234 force-pushed the 17.0-mig-account_invoice_show_currency_rate branch from 89217d8 to e5bdc73 Compare September 1, 2024 22:01
@jeer2234 jeer2234 requested a review from victoralmau September 1, 2024 22:02
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@jeer2234 jeer2234 force-pushed the 17.0-mig-account_invoice_show_currency_rate branch from cfb3ccb to 799e285 Compare September 4, 2024 16:27
@jeer2234 jeer2234 force-pushed the 17.0-mig-account_invoice_show_currency_rate branch from 799e285 to 7add58f Compare September 4, 2024 16:40
@JordiMForgeFlow
Copy link
Contributor

@jeer2234 could you include #1836?

@jeer2234
Copy link
Author

jeer2234 commented Dec 2, 2024

@JordiMForgeFlow yep, i'll do it this week.

@JordiMForgeFlow
Copy link
Contributor

@jeer2234 some FWs to consider: #1894, #1899 and #1901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.