Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [REF] account receipt print + add amount in words as option #1684

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from
Open

[14.0] [REF] account receipt print + add amount in words as option #1684

wants to merge 2 commits into from

Conversation

primes2h
Copy link
Contributor

@primes2h primes2h commented Mar 14, 2024 •
edited
Loading

  1. account_receipt_print code refactoring/optimization after these changes in account module:
    odoo/odoo@e8e4876
    odoo/odoo@8e36f62#diff-c85e75bc27fc841662ca0598c09a22670e0a0b4e5120815934c0a50999ff02bf
  2. amount in words set as option in configuration settings

amount_in_words_option

@primes2h primes2h mentioned this pull request Mar 15, 2024
Draft
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from a5b06f4 to 1668a98 Compare March 15, 2024 07:52
@primes2h primes2h mentioned this pull request Mar 16, 2024
Closed
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from 1668a98 to bbbe79b Compare March 16, 2024 18:11
mymage
mymage approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Mar 29, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch 5 times, most recently from 67146b1 to d580fc5 Compare May 31, 2024 09:35
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from d580fc5 to e47eea6 Compare July 3, 2024 13:14
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from e47eea6 to 863a0b7 Compare November 20, 2024 09:58
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from 863a0b7 to a4ff6a7 Compare January 27, 2025 10:38
@primes2h primes2h marked this pull request as draft January 27, 2025 10:41
@primes2h primes2h marked this pull request as ready for review January 27, 2025 16:02
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Jan 28, 2025
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test funzionale: OK

mymage
mymage approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mymage mymage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@primes2h primes2h mentioned this pull request Jan 28, 2025
Open
@primes2h primes2h force-pushed the 14.0-REF-account_receipt_print branch from a4ff6a7 to 63f52e1 Compare January 29, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymage mymage mymage approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@primes2h @mymage @MaurizioPellegrinet @OCA-git-bot