Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_billing #1644

Merged
merged 38 commits into from
Feb 20, 2025
Merged

[16.0][MIG] account_billing #1644

merged 38 commits into from
Feb 20, 2025

Conversation

Saran440
Copy link
Member

@Saran440 Saran440 commented Jan 12, 2024 •
edited
Loading

Migration from version14 and continue from #1406 (v15)

  • This PR enhance allow register payment (by group payment) in billing
    Selection_008
  • Add payment paid all for check move in billing is paid
  • Change name invoice_id to move_id
  • Add constraint do not allow validate if line is empty
  • Change Total to related from move_id
  • Add new field amount_residual

This PR enhance process billing for performance.
performance billing not support when user billing a lot of invoices (example is 2000 record) it take time ~ 30s

Change process billing for performance following:

  1. Create billing directly, it will not onchange when select partner
  2. Click button Compute Items for get invoices instead
    Selection_009
  3. it can reduct time from 30s to 1s (2000 record example)
    Selection_010

TODO:

  • Test script

@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch 3 times, most recently from 44ba33e to 98a6e33 Compare January 16, 2024 03:22
This was referenced Jan 16, 2024
Closed
Open
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch from 98a6e33 to 13c484f Compare January 23, 2024 04:02
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch from e9fd5f9 to 4fe2ecf Compare March 17, 2024 09:51
@Saran440 Saran440 mentioned this pull request Mar 17, 2024
Open
1 task
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch 2 times, most recently from 03b04f9 to 1678271 Compare March 18, 2024 04:31
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch 4 times, most recently from f1f845c to bad0c36 Compare March 29, 2024 10:21
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch 2 times, most recently from e6c0f83 to 168188f Compare May 16, 2024 08:53
@antonioburic antonioburic mentioned this pull request Jul 14, 2024
Open
AungKoKoLin1997
AungKoKoLin1997 approved these changes Sep 23, 2024
View reviewed changes
Copy link

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kittiu
kittiu approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@kittiu kittiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yostashiro
yostashiro reviewed Feb 15, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor fixes.

oca-travis and others added 14 commits February 19, 2025 16:05
@oca-travis @Saran440
[UPD] Update account_billing.pot
ace0621
@OCA-git-bot @Saran440
account_billing 14.0.1.0.3
d1d185d
@oca-transbot @Saran440
Update translation files
e7af601 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_billing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_billing/
@bosd @Saran440
Added translation using Weblate (Dutch (nl_NL))
18e6988
@bosd @Saran440
Translated using Weblate (Dutch (nl_NL))
8735c09 
Currently translated at 90.4% (95 of 105 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_billing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_billing/nl_NL/
@OCA-git-bot @Saran440
[UPD] README.rst
93ebb7d
@weblate @Saran440
Update translation files
2ecd054 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_billing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_billing/
@Saran440
[UPD] Update account_billing.pot
933dbef
@weblate @Saran440
Update translation files
f0f3edd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-14.0/account-invoicing-14.0-account_billing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_billing/
@Ivorra78 @Saran440
Translated using Weblate (Spanish)
e663b21 
Currently translated at 100.0% (104 of 104 strings)

Translation: account-invoicing-14.0/account-invoicing-14.0-account_billing
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-14-0/account-invoicing-14-0-account_billing/es/
@bizzappdev @Saran440
[IMP]account_billing:black, isort, prettier
612e6ce
@bizzappdev @Saran440
[MIG][15.0]account_billing:Migration to 15.0
d8c1ab2
@Saran440
[IMP] account_billing: pre-commit stuff
2f9b9c0
@Saran440
[MIG] account_billing: Migration to 16.0
c09369d
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch from e838810 to 4578d11 Compare February 19, 2025 09:06
yostashiro
yostashiro approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update!

@Saran440
Copy link
Member Author

@yostashiro Thank you for your review.

I fixing test script to inherit AccountTestInvoicingCommon
After finish, we should merge this PR.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch from 4578d11 to 4b6dd26 Compare February 19, 2025 10:08
@Saran440 Saran440 force-pushed the 16.0-mig-account_billing branch from 4b6dd26 to 52fc4b9 Compare February 19, 2025 10:14
@Saran440
Copy link
Member Author

@kittiu This PR ready to merge. please check

@kittiu
Copy link
Member

kittiu commented Feb 20, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1644-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1e59a75 into OCA:16.0 Feb 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1c570dd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittiu kittiu kittiu approved these changes

@yostashiro yostashiro yostashiro approved these changes

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.